[uart] Move to D3 #12902
Merged
[uart] Move to D3 #12902
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
chore? :) |
tjaychen
approved these changes
May 27, 2022
haha. Trying to follow https://www.conventionalcommits.org/en/v1.0.0/ codes. |
weicaiyang
approved these changes
Jun 1, 2022
a-will
approved these changes
Jun 9, 2022
jeoongp
approved these changes
Jun 15, 2022
msfschaffner
approved these changes
Jun 22, 2022
There was a problem hiding this comment.
We should also decide what to do with #83 before moving this in (but otherwise it looks like this is good to go, based on the review notes).
hw/ip/uart/doc/checklist.md
Outdated
| Code Quality | [RDC_COMPLETE][] | Not Started | | ||
| Review | [REVIEW_RTL][] | Done | by @msfschaffner | ||
| Review | [REVIEW_DELETED_FF][] | N/A | Not reported by FPGA (@eunchan double-check) | ||
| Code Quality | [CDC_COMPLETE][] | N/A | No errors on top-level |
There was a problem hiding this comment.
maybe add the same explanation for CDC/RDC/FF as suggested here:
#12892 (comment)
hw/ip/uart/doc/checklist.md
Outdated
| Review | Signoff date | Done | 2019-10-31 | ||
| Security | [SEC_NON_RESET_FLOPS][] | N/A | | ||
| Security | [SEC_SHADOW_REGS][] | N/A | | ||
| Review | Reviewer(s) | Done | |
There was a problem hiding this comment.
Can you add the following ldaps?
eunchan@ jeoong@ weicai@ awill@
| verification_stage: "V2", | ||
| dif_stage: "S2", | ||
| commit_id: "558942bb7869d9a5d8abd4bd0eb46dab820d3564" |
There was a problem hiding this comment.
this would be optional, since we don't require it when moving forward through the dev stages (we only need to record it when we bounce back and create a new version).
eunchan
force-pushed
the
uart_d3
branch
2 times, most recently
from
58ec637
to
5770164
Compare
This commit moves UART to D3 state. CDC has been reviewed at the top-level and waived Signed-off-by: Eunchan Kim <[email protected]>
msfschaffner
approved these changes
Jul 8, 2022
johngt
added
Component:DV
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit moves UART to D3 state. CDC has been reviewed at the
top-level and waived