-
Notifications
You must be signed in to change notification settings - Fork 777
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[hw,ac_range_check,rtl] Initial register description and top-level #25176
Open
Razer6
wants to merge
3
commits into
lowRISC:master
Choose a base branch
from
Razer6:ac-range-implementation
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Razer6
requested review from
andreaskurth and
vogelpi
and removed request for
msfschaffner
November 17, 2024 16:55
Razer6
force-pushed
the
ac-range-implementation
branch
4 times, most recently
from
November 18, 2024 07:32
947f4aa
to
641328e
Compare
Razer6
force-pushed
the
ac-range-implementation
branch
from
November 19, 2024 14:40
641328e
to
399b7db
Compare
Signed-off-by: Robert Schilling <[email protected]>
Signed-off-by: Robert Schilling <[email protected]>
Razer6
force-pushed
the
ac-range-implementation
branch
2 times, most recently
from
November 19, 2024 14:44
c46e56e
to
7075680
Compare
Signed-off-by: Robert Schilling <[email protected]>
Razer6
force-pushed
the
ac-range-implementation
branch
from
November 19, 2024 14:51
7075680
to
4679705
Compare
Thanks for the review @andreaskurth - I incorporated the feedback. PTAL. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements the initial register description based on the approved specification.
The IP is using
ipgen
to support different range configurations.