[sival,hmac,kmac] Update test plan and add SHA3-224 test vectors #25256
+45
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Remove KMAC test target - Specify testing all HMAC-SHA2 modes - Add test targets that exercise the SHA2 mode Signed-off-by: Miles Dai <[email protected]>
- Add cSHAKE KAT tests - Remove mentions of XOF from KMAC testpoint. These are covered by the SHAKE and cSHAKE testpoints. - Add hardcoded KMAC test vectors Signed-off-by: Miles Dai <[email protected]>
Signed-off-by: Miles Dai <[email protected]>
milesdai
added
the
CherryPick:earlgrey_1.0.0
jadephilipoom
approved these changes
Nov 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates some of the HMAC and KMAC test points and adds missing SHA3-224 test vectors.
CC @nmoroze