Skip to content
This repository has been archived by the owner on Mar 8, 2020. It is now read-only.

[3:3:2:2] When approving a Partner, wait for the response before updating the status #1

Open
3 tasks
armahillo opened this issue Jan 24, 2019 · 0 comments
Assignees

Comments

@armahillo
Copy link
Collaborator

armahillo commented Jan 24, 2019

(Pulled from RfG#672)

Note - This requires work on both the diaper and partner apps. Each point below will require altering the api endpoint on each app as well as whatever is making the request to the endpoint.

Summary

In the partners_controller.rb there is an action #approve_application that automatically sets a partner status to approved. Instead, it should wait for the results of DiaperPartnerClient.put before making the change. Scheduled retries or something similar my be required.

Criteria for Completion

  • A passing test that confirms that the status is NOT set if the put fails
  • A passing test that confirms the status is set if the put is successful
  • Verification from the Partner app that any additional work on that end is working

Reference / History

This was originally part of https://github.com/rubyforgood/diaper/issues/636. It is similar to #2

@armahillo armahillo changed the title When approving a Partner, wait for the response before updating the status [3] When approving a Partner, wait for the response before updating the status Jan 24, 2019
@Maddiefayee Maddiefayee self-assigned this Feb 5, 2019
@nihonjinrxs nihonjinrxs changed the title [3] When approving a Partner, wait for the response before updating the status [3:3] When approving a Partner, wait for the response before updating the status Feb 12, 2019
@nihonjinrxs nihonjinrxs changed the title [3:3] When approving a Partner, wait for the response before updating the status [3:3:2] When approving a Partner, wait for the response before updating the status Mar 12, 2019
@nihonjinrxs nihonjinrxs changed the title [3:3:2] When approving a Partner, wait for the response before updating the status [3:3:2:2] When approving a Partner, wait for the response before updating the status Mar 26, 2019
@madelashmet madelashmet reopened this Apr 26, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.