Skip to content
This repository has been archived by the owner on Mar 8, 2020. It is now read-only.

[3:3] Require that update_diaper_partner is successful before advancing to pending status #2

Open
2 tasks
armahillo opened this issue Jan 24, 2019 · 0 comments
Assignees

Comments

@armahillo
Copy link
Collaborator

armahillo commented Jan 24, 2019

(Pulled from RfG#671 )
Note - This requires work on both the diaper and partner apps. Each point below will require altering the api endpoint on each app as well as whatever is making the request to the endpoint.

Summary

In the Diaper app in the partner.rb model there is a method update_diaper_partner that immediately sets the partner status to pending regardless if the DiaperPartnerClient.post(attributes) was successful or not. We need to ensure that the post action was successful and then set the partner status to pending. We may need to schedule a retry on a fail or something similar.

Criteria for Completion

  • A passing test that confirms that the status is NOT set if the post fails
  • A passing test that confirms the status is set if the post is successful

Reference / History

This was originally part of #636, and is related to #1

@armahillo armahillo changed the title Require that update_diaper_partner is successful before advancing to pending status When approving a Partner, wait for the response before updating the status Jan 24, 2019
@armahillo armahillo changed the title When approving a Partner, wait for the response before updating the status Require that update_diaper_partner is successful before advancing to pending status Jan 24, 2019
@nihonjinrxs nihonjinrxs changed the title Require that update_diaper_partner is successful before advancing to pending status [3] Require that update_diaper_partner is successful before advancing to pending status Jan 25, 2019
@Maddiefayee Maddiefayee assigned ghost Feb 5, 2019
@madelashmet madelashmet self-assigned this Feb 12, 2019
@nihonjinrxs nihonjinrxs changed the title [3] Require that update_diaper_partner is successful before advancing to pending status [3:3] Require that update_diaper_partner is successful before advancing to pending status Feb 12, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants