Add list of speakers #143

MikeRogers0 · 2020-11-25T17:40:54Z

Issue: #31

The aim of this is to create a list of the most recent speakers which is easy to keep up to date.

TODO

Setup a nice design for displaying speakers
Setup redirect
Verify all speaker data collected from markdown files is accurate (It has some duplicate links & linking to the wrong person).
Add pagination if required? Maybe some kind of search also.

MikeRogers0 · 2020-11-25T17:42:03Z

data/speakers.json

+{
+  "Mike Rogers": {
+    "profile": {
+      "github_username": "MikeRogers0"


The cool thing about GitHub is we can pull a bunch more data about the speaker via their API without an API key.

h-lame

I know this is a draft so not sure what sort of early feedback you're looking for, but I've left some thoughts anyway. Quite excited to see something come together on this though, thanks for tackling it!

Gemfile.lock

source/speakers/index.html.erb

h-lame · 2020-11-25T22:23:38Z

source/speakers/index.html.erb

+        <p>
+          <%= link_to speaker.blog, speaker.blog %>
+        </p>
+      </div>


I know we've taken inspiration from some other website on this, but I'm pretty sure we'll never get most of these details, so lets pare it right back. I quite like the svg icons for the twitter / GitHub links, but I also know that without a huge amount of effort we're probably not going to get twitter and GitHub links for most of our speakers, and for some we don't even have those, some folk just link to LinkedIn and personal websites were the preferred link back in the past. Perhaps we can just introspect on the one link we do have and render an appropriate icon?

Perhaps we can just introspect on the one link we do have and render an appropriate icon?

I agree :) I was hoping to find a way to pull in a bit more information, I think I'll save that for another PR :)

h-lame · 2020-11-25T22:25:53Z

lib/speaker_helpers.rb

+  def all_speakers
+    data.speakers
+      .collect { |name, speaker_data| Speaker.new(name, speaker_data) }
+      .sort_by { |speaker| speaker.name }


I wonder if we should order this by recency of the speakers talks, so it changes once each meeting is published to show the most recent speakers? I don't think sorting by frequency of talks is a good idea, but maybe recency is weird. We've enough speakers that maybe we'd want A..Z in page navigation so doing anything other than alphabetical is weird?

I agree we should sort by most recently published, I think it's possible now I've figured out a way to pull the coverage data into a easier to work with format.

lib/speaker_helpers.rb

MikeRogers0 · 2020-12-05T20:14:55Z

I'm still working on this, but would love some thoughts on the best way to populate a list of speakers and their talks @h-lame :)

The approach I'm currenting is to parse all the source/meetings/*/*/index.html.md files, searching for ## Agenda heading, then from there figuring the the talk title & the speaker (So the first link after the H3, then the following coverage or the speakers talk summary). What do you think?

MikeRogers0 · 2020-12-05T21:53:53Z

Pretty exciting & a Work in progress, but I figured out a way to extract most the speaker data from previous meetings.

My plan is to export it into a data file, which we can then use to display all the previous speakers & their talks 👍

…t it's looking good

MikeRogers0 · 2020-12-06T23:22:31Z

@h-lame - What do you think of the http://127.0.0.1:4567/speakers/index.html page? I still need to fix a few of the entries (e.g. where it says the author name is "Redis" & links are duplicated.), but I think I'm on the right path :D

Approach wise: Once I nail down the data, we could potentially have display all the previous speakers with their talks. Then maybe in a future PR we could add a search.

h-lame · 2020-12-07T21:03:12Z

source/speakers/index.html.erb

+            <% elsif speaker_link.include?('github.com') %>
+              <%= image_tag 'github.svg', width: 24, height: 24 %>
+            <% else %>
+              🔗


Can we get an SVG for a standard link svg too? I don't know where the twitter and GitHub ones came from, but the link emoji looks different and has a different baseline, so hopefully we can get a link svg from the same place.

h-lame · 2020-12-07T21:03:54Z

source/speakers/index.html.erb

+
+      <ul>
+        <% speaker.talks.each do |talk| %>
+          <li><%= link_to talk[:title], "/meetings/#{talk[:year]}/#{talk[:month]}/" %> - <%= talk[:month] %> <%= talk[:year] %></li>


Minor but let's titlecase the month:

Suggested change

<li><%= link_to talk[:title], "/meetings/#{talk[:year]}/#{talk[:month]}/" %> - <%= talk[:month] %> <%= talk[:year] %></li>

<li><%= link_to talk[:title], "/meetings/#{talk[:year]}/#{talk[:month]}/" %> - <%= talk[:month].titlecase %> <%= talk[:year] %></li>

h-lame · 2020-12-07T21:09:38Z

lib/generate_speaker_list/generator.rb

+    end
+
+    def save_authors_to_json!
+      File.write(SPEAKERS_DATA_FILE, JSON.pretty_generate(@authors))


Be nice if this file was sorted by name so it's easier to look through and easier to edit as we add things for future meetings. Thinking particularly of the case where we have to add a new talk to an existing speaker. The current order is weird so would get out of hand quickly as we added to it.

h-lame

Looking good so far. The biggest hurdle is going to be the data. I think you've done a great job on extracting what we have, but a cursory skim through the file does suggest there's a lot of tidy up to do.

I think we could try a different parsing approach, tweak what we have, or just do a manual fix up. Not sure what would be best TBH.

What strikes me as odd is we now have speakers.json that has {::coverage ...} links in it to the contents of data/coverage/*.yml and I wonder, if all this should be data/talks/*.yml and we slice and dice what we pull out of those into different structures to support the different rendering purposes in the app?

h-lame · 2020-12-07T21:24:52Z

lib/generate_speaker_list/generator.rb

+    def call
+      load_all_talks_from_files!
+
+      @talks = @talks.flatten.select { |talk| talk[:author] != nil }.group_by { |talk| talk[:author] }


There's nothing in the file for talks from before 2010. I know the structure of the write-ups has changed a bit, but not by a huge amount I don't think. So it's weird there's nothing in there from those early meetings.

In the json file I've spotted a few weird speaker names where we've got a greedy regexp match on names with multiple links in them. So I wonder if we should revisit the parsing approach in general? Would we get better results if we rendered the page from markdown -> HTML and then parse with nokogiri? Or maybe we render into Kramdowns internal structure and walk parse that?

MikeRogers0 · 2021-04-04T19:58:45Z

I'm a little bit slammed & I don't think I'll be able to complete this. Instead of leaving it hanging, I'm going to close it off & come back to it when I have more time.

MikeRogers0 added 3 commits November 18, 2020 17:48

I bundled while running Ruby 2.7.2 😈

bac82f5

Outputting all the videos onto a single page

42525a5

Loading speaker profile from GitHub where possible

2068f94

MikeRogers0 commented Nov 25, 2020

View reviewed changes

h-lame reviewed Nov 25, 2020

View reviewed changes

MikeRogers0 mentioned this pull request Nov 26, 2020

Updating to ruby 2.7.2 #144

Merged

MikeRogers0 added 2 commits December 5, 2020 19:47

Merge branch 'master' into feature/add-list-of-speakers

6bc05eb

Ditching the "load info from GitHub API" approach

92b581b

MikeRogers0 added 3 commits December 5, 2020 20:52

I think we can totally parse the files looking for the H3 & coverage

986ae37

Pulling out all the speaker & coverage data from the markdown

54b7ffb

Sorting the file order

e22c486

MikeRogers0 added 6 commits December 5, 2020 21:58

Now I've got all the coverage data I need for now, I'm don't need this

78adcc8

Removign httparty - we don't need it anymore

ef2e65f

Outputting speakers list to JSON file - the format is still wrong, bu…

a2e0635

…t it's looking good

Making sure middleman can start

81d1e88

Ouputting speakers & their talks more nicely on /speakers

d05d78b

HTML feels unsemantic - I'll fix later

69a320b

h-lame reviewed Dec 7, 2020

View reviewed changes

MikeRogers0 closed this Apr 4, 2021

MikeRogers0 deleted the feature/add-list-of-speakers branch April 4, 2021 19:58

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add list of speakers #143

Add list of speakers #143

MikeRogers0 commented Nov 25, 2020 •

edited

Loading

MikeRogers0 Nov 25, 2020

h-lame left a comment

h-lame Nov 25, 2020

MikeRogers0 Dec 5, 2020

h-lame Nov 25, 2020

MikeRogers0 Dec 5, 2020

MikeRogers0 commented Dec 5, 2020 •

edited

Loading

MikeRogers0 commented Dec 5, 2020

MikeRogers0 commented Dec 6, 2020 •

edited

Loading

h-lame Dec 7, 2020

h-lame Dec 7, 2020

h-lame Dec 7, 2020

h-lame left a comment

h-lame Dec 7, 2020

MikeRogers0 commented Apr 4, 2021

	<li><%= link_to talk[:title], "/meetings/#{talk[:year]}/#{talk[:month]}/" %> - <%= talk[:month] %> <%= talk[:year] %></li>
	<li><%= link_to talk[:title], "/meetings/#{talk[:year]}/#{talk[:month]}/" %> - <%= talk[:month].titlecase %> <%= talk[:year] %></li>

Add list of speakers #143

Add list of speakers #143

Conversation

MikeRogers0 commented Nov 25, 2020 • edited Loading

TODO

Choose a reason for hiding this comment

h-lame left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

MikeRogers0 commented Dec 5, 2020 • edited Loading

MikeRogers0 commented Dec 5, 2020

MikeRogers0 commented Dec 6, 2020 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

h-lame left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

MikeRogers0 commented Apr 4, 2021

MikeRogers0 commented Nov 25, 2020 •

edited

Loading

MikeRogers0 commented Dec 5, 2020 •

edited

Loading

MikeRogers0 commented Dec 6, 2020 •

edited

Loading