-
Notifications
You must be signed in to change notification settings - Fork 305
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Development
: Extract plagiarism detection service
#7152
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-detection-service
…-detection-service
MarkusPaulsen
previously approved these changes
Sep 16, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks good + Tested on TS1
7ffdc1a
krusche
reviewed
Sep 30, 2023
src/main/java/de/tum/in/www1/artemis/domain/plagiarism/PlagiarismDetectionConfig.java
Outdated
Show resolved
Hide resolved
Plagiarism detection
: Extract plagiarism detection servicePlagiarism checks
: Extract plagiarism detection service
Plagiarism checks
: Extract plagiarism detection serviceDevelopment
: Extract plagiarism detection service
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
client
Pull requests that update TypeScript code. (Added Automatically!)
maintainer-approved
The feature maintainer has approved the PR
ready to merge
server
Pull requests that update Java code. (Added Automatically!)
tests
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
General
Server
Changes affecting Programming Exercises
Motivation and Context
Plagiarism detection logic is distributed in controllers for each exercise type resources. This logic has a common domain and could be stored in a dedicated class. The current state will also require a copy&paste approach in case on implementing new triggers for plagiarism detection, like continuous plagiarism control.
Description
This PR introduces a common
PlagiarismDetectionService
which own all plagiarism checks related logic. This class is implemented using the code moved fromModelingExerciseResource
,TextExerciseResource
andProgrammingExercisePlagiarismResource
classes.There is a new
PlagarismDetectionConfig
class, which holds the configuration for plagiarism checks. This is the first step that enables this config to be stored on the server, which will be necessary for the continuous plagiarism control in the future.Steps for Testing
Prerequisites:
Review Progress
Performance Review
Code Review
Manual Tests
Test Coverage