Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing unused jobs #1040

Merged
merged 2 commits into from
Nov 19, 2024
Merged

Removing unused jobs #1040

merged 2 commits into from
Nov 19, 2024

Conversation

roceb
Copy link
Contributor

@roceb roceb commented Nov 5, 2024

No description provided.


// it would be slick if we could trigger based on dockerhub lsstsqre/centos
// notifications but AFAIK, this can't be restricted by tag
upstream('sqre/infra/build-layercake', 'SUCCESS')
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this means that build-layercake can go away as well.

scm {
git {
remote {
github('lsst-sqre/sqre-codekit')
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think Build Engineering needs to take over ownership of this. SQuaRE isn't going to use it for anything. We should then replace this trigger with a GHA.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have taken over this and have replaced it with GHA

scm {
git {
remote {
github('lsst-sqre/tag-monger')
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking at what this repo does, I think something like it may be necessary. We can't keep all eups package artifacts forever. But we do want to keep official releases, so a simple time-based lifecycle policy won't work.

That doesn't mean we need to keep this job, but we need to plan to replace this code somehow.

jobs/clean_builds.groovy Outdated Show resolved Hide resolved
@@ -1,10 +0,0 @@
import util.Plumber

def p = new Plumber(name: 'sqre/ci-ci/ghslacker', dsl: this)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This has been replaced by SQuaRE's checkerboard service that Build Engineering is not responsible for.

Removal is correct.

scm {
git {
remote {
github('lsst-sqre/git-lfs-s3-server')
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Again, SQuaRE owns git-lfs. Removal is correct.

@@ -1,38 +0,0 @@
import util.Plumber

def p = new Plumber(name: 'release/codekit/github-tag-release', dsl: this)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one is used in the nightly/weekly/official release jobs. It can't be removed.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, it looks like this job is not used, as the release jobs invoke the same code directly, not via the job. Removal is OK.

@@ -1,29 +0,0 @@
import util.Plumber

def p = new Plumber(name: 'release/codekit/github-tag-teams', dsl: this)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Similarly, this is used in the nightly/weekly/official releases for auxiliary repos. Don't remove it.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, it looks like this job is not used, as the release jobs invoke the same code directly, not via the job. Removal is OK.

@@ -1,66 +0,0 @@
node('jenkins-manager') {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't remove this one.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, it looks like this pipeline is not used, as the release jobs invoke the same code directly, not via the pipeline. Removal is OK.

@@ -1,32 +0,0 @@
node('jenkins-manager') {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't remove this one.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, it looks like this pipeline is not used, as the release jobs invoke the same code directly, not via the pipeline. Removal is OK.

@roceb roceb requested a review from ktlim November 15, 2024 05:53
@roceb roceb merged commit d8b5d1c into main Nov 19, 2024
4 checks passed
@roceb roceb deleted the tickets/DM-47324 branch November 19, 2024 22:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants