Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DM-28328: Build docs in stack-os-matrix #791

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Conversation

ktlim
Copy link
Contributor

@ktlim ktlim commented Apr 23, 2021

No description provided.

@ktlim ktlim requested a review from athornton April 23, 2021 16:07
@@ -11,16 +11,15 @@ p.pipeline().with {
stringParam('REFS', null, 'Whitespace delimited list of "refs" to attempt to build. Priority is highest -> lowest from left to right. "master" or branch from repos.yaml is implicitly appended to the right side of the list, if not specified; do not specify "master" explicitly.')
stringParam('PRODUCTS', scipipe.canonical.products,
'Whitespace delimited list of EUPS products to build.')
booleanParam('BUILD_DOCS', true, 'Build pipelines.lsst.io site')
booleanParam('PUBLISH_DOCS', true, 'Publish pipelines.lsst.io/v edition')
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How does it know where to publish that in the /v tree? Does it combine all the ticket branches that have been specified for the build? I see some code later that looks like it might be doing that and replacing space with -.

Do we clean them out periodically?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's based on the git refs, yes, and it combines all ticket branches, as requested in the ticket.

I don't think we clear them out at present. @jonathansick ?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't delete old editions at present but that's a feature we have in mind for LSST the Docs.

@@ -20,7 +20,7 @@ p.pipeline().with {
booleanParam('WIPEOUT', false, 'Completely wipe out workspace(s) before starting build.')
stringParam('TIMEOUT', '8', 'build timeout in hours')
stringParam('IMAGE', null, 'Pipeline base docker image (e.g. docker.io/lsstdm/scipipe-base:8 or empty for macOS)')
choiceParam('LABEL', ['centos-8-conda', 'centos-7-conda', 'osx-10.11', 'osx-10.12', 'osx-10.14'], 'Jenkins build agent label')
choiceParam('LABEL', ['centos-8-conda', 'centos-7-conda', 'osx-10.13', 'osx-10.14'], 'Jenkins build agent label')
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is centos-8 still a thing?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For test pipelines, perhaps.

@ktlim ktlim force-pushed the tickets/DM-28328 branch from 27b3b93 to bb8429d Compare April 23, 2021 16:55
@ktlim ktlim force-pushed the tickets/DM-28328 branch from bb8429d to 78d49dd Compare April 23, 2021 22:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants