DM-48885: Add support for configuring number of messages to be consumed and timeout in salobj Remote/SalInfo. #309
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tribeiro
force-pushed
the
tickets/DM-48885
branch
from
0db7aa4 to
30cc7b4
Compare
pkubanek
reviewed
Feb 12, 2025
python/lsst/ts/salobj/sal_info.py
Outdated
| f"Failed to deserialize {schema_resolution_errors[kafka_name]} samples of " | ||
| f"{kafka_name}. Check schema compatibility!" | ||
| for message in messages: | ||
| message_error = message.error() |
There was a problem hiding this comment.
Keeping message processing leads to quite big indentation, which makes code harder to read. Can you please create a method to process messages, so the code (assuming it's called _process_message) will shrink to:
for message in messages:
self._process_messaeg(message)
pkubanek
reviewed
Feb 12, 2025
doc/news/README.rst
Outdated
| @@ -0,0 +1,40 @@ | |||
| Recording Changes | |||
| ================= | |||
|
|
|||
There was a problem hiding this comment.
There is an empty space. Not a big deal, but if you can get rid of those (:%s/ *$//g in vim), that will save some bits.
…xpose parameters to allow users to select the number of messages and timeout. By default this uses num_messages=1 and timeout=0.1, which fallbacks to the behaviour of pool with timeout=0.1. Users must be careful when using this feature as it will affect command and event response in some non-obvious way.
…nd timeout on the read loop.
…sages and consume_messages_timeout.
…ages and consume_messages_timeout.
…ages_timeout has the expected behavior.
…num_messages and consume_messages_timeout.
tribeiro
force-pushed
the
tickets/DM-48885
branch
from
30cc7b4 to
f7f9e5c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.