Add tiled vae encoding/decoding toggle to detailer nodes #883
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It looks good. I'll test it first later. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tiled vae encoding/decoding is more optimal sometimes, it can prevent upsteam non-tiled encode/decode from failing and internally falling back to tiled versions. So it is nice to have the option.
This version uses the upstream tiled-vae node default settings, which aren't currently configurable. The default detailer config has tiling disabled so this should be a non-breaking change.
We could simplify it a bit and just have a single option for "tiled_vae" that applies to both encode & decode. Let me know if you'd prefer that.
This PR also includes basic logging for how long vae operations take. I can remove these if you prefer.
Resolves #667
Resolves #822