Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to egui 0.29.0 & Enhancements #37

Merged
merged 16 commits into from
Sep 28, 2024
Merged

Update to egui 0.29.0 & Enhancements #37

merged 16 commits into from
Sep 28, 2024

Conversation

bircni
Copy link
Contributor

@bircni bircni commented Sep 26, 2024

No description provided.

@bircni
Copy link
Contributor Author

bircni commented Sep 26, 2024

Just noticed
In egui_flex are many unused variables and dead code - I will remove them in a seperate commit - please tell me if you want that, else I will remove this commit then

@lucasmerlin
Copy link
Owner

Awesome, thank you 🙏

Yeah I need to do a final clean up / documentation pass before I publish egui_flex, I plan to publish it next week. If you want to clean it up beforehand, that would be appreciated!

@bircni
Copy link
Contributor Author

bircni commented Sep 26, 2024

i can try :-)

What about linting?
Should I enable some lints too?

@bircni bircni changed the title Update egui_animation Update to egui 0.29.0 & Enhancements Sep 26, 2024
Copy link
Owner

@lucasmerlin lucasmerlin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thank you so much!

Cargo.toml Show resolved Hide resolved
crates/egui_dnd/src/item.rs Outdated Show resolved Hide resolved
crates/egui_dnd/src/item.rs Outdated Show resolved Hide resolved
crates/egui_dnd/src/item_iterator.rs Outdated Show resolved Hide resolved
crates/egui_flex/examples/flex_customize_example.rs Outdated Show resolved Hide resolved
crates/egui_router/src/transition.rs Outdated Show resolved Hide resolved
crates/egui_virtual_list/src/lib.rs Outdated Show resolved Hide resolved
crates/hello_egui_utils/src/center.rs Outdated Show resolved Hide resolved
fancy-example/src/chat.rs Outdated Show resolved Hide resolved
fancy-example/src/chat.rs Show resolved Hide resolved
@Ruttie2006
Copy link

Since this PR is arbitrarily named 'enhancements', would adding #36 to this pr be possible?

@lucasmerlin
Copy link
Owner

lucasmerlin commented Sep 28, 2024

Since this PR is arbitrarily named 'enhancements', would adding #36 to this pr be possible?

I'd prefere a separate one since this one is already reeeeally big

@bircni
Copy link
Contributor Author

bircni commented Sep 28, 2024

I'd prefere a separate one since this one is already reeeeally big

Ooops xD

@bircni bircni requested a review from lucasmerlin September 28, 2024 22:14
@bircni
Copy link
Contributor Author

bircni commented Sep 28, 2024

Now everything should be ready to merge :-)

https://github.com/bircni/hello_egui/actions/runs/11087433518

@bircni
Copy link
Contributor Author

bircni commented Sep 28, 2024

Maybe we could also set all versions on the same version number as egui is. So it has the same number and all crate versions here can be managed by the main cargo.toml file with the workspace.

This could be done in a seperate PR maybe... - tell me if you want that

@lucasmerlin
Copy link
Owner

Maybe we could also set all versions on the same version number as egui is

I actually thought about that before but decided against it because it would mean I can't release a breaking change to a crate until the next egui release. For now I'm fine with separate versions (cargo release makes this really easy to manage)

@bircni
Copy link
Contributor Author

bircni commented Sep 28, 2024

Do you still need something from me or is it done then?😅

@lucasmerlin lucasmerlin merged commit bd11422 into lucasmerlin:main Sep 28, 2024
4 checks passed
@lucasmerlin
Copy link
Owner

It's done, I was just waiting on the pipeline 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants