Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mock S3 with folder in dev/testing #171

Open
redshiftzero opened this issue Jan 24, 2017 · 4 comments · May be fixed by #851
Open

Mock S3 with folder in dev/testing #171

redshiftzero opened this issue Jan 24, 2017 · 4 comments · May be fixed by #851
Labels
hackathon

Comments

@redshiftzero
Copy link
Member

redshiftzero commented Jan 24, 2017 •
edited
Loading

In PR #169 I added this serve_image function in utils.py that generates a path for the files stored locally in the static/ folder. However in prod and staging images are actually stored on S3. It'd be nice to better mock the S3 setup in dev/testing to be as close as possible to prod/staging (suggested by @r4v5).
@redshiftzero redshiftzero added this to the 0.3 milestone Jan 24, 2017
@redshiftzero redshiftzero changed the title Mock S3 with folder Mock S3 with folder in dev/testing Jan 24, 2017
@redshiftzero redshiftzero removed this from the 0.4 milestone Nov 8, 2017
@ssempervirens ssempervirens mentioned this issue Mar 19, 2018
Closed
@raq929
Copy link

raq929 commented Jun 6, 2018

It turns out that I didn't need this for the other issue, but for future reference, boto 1.10 has it's own nice stubber for s3.

@fritzdavenport
Copy link
Contributor

Finishing this puppy up, encountering an unexpected error in test_functional but all other tests and functionality passes. Expect PR soon

@fritzdavenport fritzdavenport mentioned this issue Aug 3, 2020
Closed
3 tasks
@fritzdavenport
Copy link
Contributor

Finished - tests pass locally but die on Travis. Struggling with getting much info for it :/

@abandoned-prototype
Copy link
Collaborator

Hi @fritzdavenport. Thanks for your work on this!
I am pretty excited about having this for local development. I just checked out your branch and ran make test and got the exact same errors that travis is getting 16 passed, 330 error. So maybe you are able to recreate those failures by throwing some docker images away or something

@abandoned-prototype abandoned-prototype linked a pull request Nov 10, 2020 that will close this issue
Open
3 tasks
AetherUnbound added a commit that referenced this issue Apr 9, 2023
@sea-kelp @AetherUnbound
Update "Find an Officer" page (#171)
8b00aec 
* Update "Find an Officer" page

* Update OpenOversight/app/templates/list_officer.html

Co-authored-by: Madison Swain-Bowden <[email protected]>

Co-authored-by: Madison Swain-Bowden <[email protected]>
@michplunkett michplunkett self-assigned this Jul 19, 2023
@michplunkett michplunkett removed their assignment Aug 25, 2023
@michplunkett michplunkett self-assigned this Oct 8, 2024
@michplunkett michplunkett removed their assignment Oct 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
hackathon
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

171/s3 local lucyparsons/OpenOversight
S3 fritzdavenport/OpenOversight
5 participants
@michplunkett @fritzdavenport @redshiftzero @raq929 @abandoned-prototype