Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

converts tiff and psd photo submissions to jpeg #404

Closed
wants to merge 1 commit into from

Conversation

ssempervirens
Copy link
Member

@ssempervirens ssempervirens commented Mar 19, 2018

Status

this code should work, but cannot test because I can't set up a mock S3 bucket (open issue #171)

Description of Changes

Fixes #369 .

Changes proposed in this pull request:

  • Converts tiff and psd file submissions to jpegs

Notes for Deployment

Screenshots (if appropriate)

Tests and linting

[x] I have rebased my changes on current develop

[ ] pytests pass in the development environment on my local machine

[ ] flake8 checks pass

converts tiff and psd submissions to jpeg
@b-meson
Copy link
Member

b-meson commented Mar 19, 2018

@magpiewings and I are taking a look at the tests and I think adding a new key to config.py is not the right way of doing this. thinking of a line like this if allowed_file.extension == '.psd' or allowed_filed.extension == 'tiff': on line 481 inviews.py` is a better way of doing this.

@ssempervirens
Copy link
Member Author

@b-meson is trying to do something similar in the same place, stripping metadata from jpegs, so we will need to discuss the best way to check file extensions

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants