Omit DB migrations folder from Coveralls report #1149
Draft
+4
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michplunkett
changed the title
michplunkett
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
We currently consider the
migrations/versionsfolder in the Coveralls report, but we don't to any meaningful testing on it so it tanks our numbers and is not representative or useful with regard to our testing strategy. To make our numbers more accurately reflective of our intentions, I omitted themigrations/versionsfrom the coverage report.Documentation: link
Screenshots (if appropriate)
Tests and Linting
developbranch.make create_db_diagramcommand.pytestpasses on my local development environment.pre-commitpasses on my local development environment.