Center and size officer profile pictures #974
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michplunkett
commented
Jul 14, 2023
| @@ -585,10 +585,44 @@ tr:hover .row-actions { | |||
| } | |||
|
|
|||
| .officer-face { | |||
| border: none; | |||
There was a problem hiding this comment.
Before:
After:
michplunkett
commented
Jul 14, 2023
Comment on lines
+616
to
+622
| #face-img { | ||
| border: none; | ||
| display: block; | ||
| margin: auto; | ||
| max-height: 500px; | ||
| padding-bottom: 10px; | ||
| } |
There was a problem hiding this comment.
Before:
After:
michplunkett
commented
Jul 14, 2023
Comment on lines
+593
to
+595
| .officer-face.officer-profile { | ||
| display: block; | ||
| } |
There was a problem hiding this comment.
this looks as a great way to show the problem in a way that the "before" screenshot didn't above.
michplunkett
commented
Jul 14, 2023
Comment on lines
+597
to
+601
| @media (min-width: 992px) { | ||
| .officer-face.officer-profile { | ||
| height: 510px; | ||
| } | ||
| } |
michplunkett
commented
Jul 14, 2023
Comment on lines
+603
to
+607
| @media (min-width: 768px) and (max-width: 991px) { | ||
| .officer-face.officer-profile { | ||
| height: 590px; | ||
| } | ||
| } |
michplunkett
commented
Jul 14, 2023
Comment on lines
+609
to
+614
| @media (max-width: 767px) { | ||
| .officer-face.officer-profile { | ||
| height: 460px; | ||
| padding-bottom: 10px; | ||
| } | ||
| } |
michplunkett
changed the title
b-meson
approved these changes
Jul 17, 2023
Comment on lines
+593
to
+595
| .officer-face.officer-profile { | ||
| display: block; | ||
| } |
There was a problem hiding this comment.
this looks as a great way to show the problem in a way that the "before" screenshot didn't above.
sea-kelp
pushed a commit
to OrcaCollective/OpenOversight
that referenced
this pull request
Sep 6, 2023
## Fixes issue lucyparsons#931 ## Description of Changes I centered and addressed sizing issues with the officer profile pictures in the profile page, officer list page, and officer image page. ## Screenshots (if appropriate) Located in the comments. ## Tests and linting - [x] This branch is up-to-date with the `develop` branch. - [x] `pytest` passes on my local development environment. - [x] `pre-commit` passes on my local development environment.
sea-kelp
pushed a commit
to OrcaCollective/OpenOversight
that referenced
this pull request
Sep 25, 2023
## Fixes issue lucyparsons#931 ## Description of Changes I centered and addressed sizing issues with the officer profile pictures in the profile page, officer list page, and officer image page. ## Screenshots (if appropriate) Located in the comments. ## Tests and linting - [x] This branch is up-to-date with the `develop` branch. - [x] `pytest` passes on my local development environment. - [x] `pre-commit` passes on my local development environment.
sea-kelp
pushed a commit
to OrcaCollective/OpenOversight
that referenced
this pull request
Oct 5, 2023
## Fixes issue lucyparsons#931 ## Description of Changes I centered and addressed sizing issues with the officer profile pictures in the profile page, officer list page, and officer image page. ## Screenshots (if appropriate) Located in the comments. ## Tests and linting - [x] This branch is up-to-date with the `develop` branch. - [x] `pytest` passes on my local development environment. - [x] `pre-commit` passes on my local development environment.
AetherUnbound
pushed a commit
to OrcaCollective/OpenOversight
that referenced
this pull request
Oct 9, 2023
## Fixes issue lucyparsons#931 ## Description of Changes I centered and addressed sizing issues with the officer profile pictures in the profile page, officer list page, and officer image page. ## Screenshots (if appropriate) Located in the comments. ## Tests and linting - [x] This branch is up-to-date with the `develop` branch. - [x] `pytest` passes on my local development environment. - [x] `pre-commit` passes on my local development environment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue
#931
Description of Changes
I centered and addressed sizing issues with the officer profile pictures in the profile page, officer list page, and officer image page.
Screenshots (if appropriate)
Located in the comments.
Tests and linting
developbranch.pytestpasses on my local development environment.pre-commitpasses on my local development environment.