Simplified logic on disable and enable operation (#5)

* using modprobe module instead of shell

Signed-off-by: Lukas Bednar <[email protected]>

tasks/main.yml

@@ -36,11 +36,6 @@
     cat {{ nested_virtualization_test_path }}
   register: actual_status
 
-- include_tasks: enable.yml
-  when:
-    - nested_virtualization_state == "enabled"
-    - "'N' in actual_status.stdout or '0' in actual_status.stdout"
-
 - name: "Persist configuration in {{ nested_virtualization_kvm_config }}"
   lineinfile:
     path: "{{ nested_virtualization_kvm_config }}"
@@ -50,16 +45,25 @@
   when:
     - nested_virtualization_state == "enabled"
 
-- include_tasks: disable.yml
-  when:
-    - nested_virtualization_state == "disabled"
-    - "'Y' in actual_status.stdout or '1' in actual_status.stdout"
-
 - name: "Persist configuration in {{ nested_virtualization_kvm_config }}"
   lineinfile:
     path: "{{ nested_virtualization_kvm_config }}"
     regexp: "^options {{ nested_virtualization_module_name }}.*$"
-    line: "options {{ nested_virtualization_module_name }}"
+    state: absent
     create: yes
   when:
     - nested_virtualization_state == "disabled"
+
+# Desired state is enabled but real state is off
+- name: "Reload {{ nested_virtualization_module_name }} module"
+  include_tasks: reload-module.yml
+  when:
+    - nested_virtualization_state == "enabled"
+    - "'N' in actual_status.stdout or '0' in actual_status.stdout"
+
+# Desired state is disabled but real state is on
+- name: "Reload {{ nested_virtualization_module_name }} module"
+  include_tasks: reload-module.yml
+  when:
+    - nested_virtualization_state == "disabled"
+    - "'Y' in actual_status.stdout or '1' in actual_status.stdout"

tasks/reload-module.yml

@@ -0,0 +1,10 @@
+---
+- name: "Remove {{ nested_virtualization_module_name }} module"
+  modprobe:
+    name: "{{ nested_virtualization_module_name }}"
+    state: absent
+
+- name: "Load {{ nested_virtualization_module_name }} module"
+  modprobe:
+    name: "{{ nested_virtualization_module_name }}"
+    state: present

tests/test.yml

@@ -26,4 +26,4 @@
   hosts: docker_containers
   roles:
     - role: "nested-virtualization"
-      nested_virtualization_state: disable
+      nested_virtualization_state: "disabled"