bugfix for lineheight unit when pixel

lukasoppermann · Aug 22, 2021 · b2b04fa · b2b04fa
1 parent 6b4e626
commit b2b04fa
Show file tree

Hide file tree

Showing 9 changed files with 86,436 additions and 106 deletions.
diff --git a/_resources/Plugin Icon.png b/_resources/Plugin Icon.png
diff --git a/_resources/design-tokens-v5.jpg b/_resources/design-tokens-v5.jpg
diff --git a/_resources/promo-v5.jpg b/_resources/promo-v5.jpg
diff --git a/dist/plugin.js b/dist/plugin.js
diff --git a/dist/ui.html b/dist/ui.html
diff --git a/dist/ui.js b/dist/ui.js
diff --git a/src/extractor/extractFonts.ts b/src/extractor/extractFonts.ts
@@ -113,7 +113,7 @@ const extractFonts: extractorInterface = (tokenNodes: TextStyle[], prefixArray:
       lineHeight: {
         // @ts-ignore
         value: roundWithDecimals(node.lineHeight.value) || 'normal',
-        unit: node.lineHeight.unit.toLowerCase(),
+        unit: node.lineHeight.unit.toLowerCase() === 'pixels' ? 'pixel' : node.lineHeight.unit.toLowerCase(),
         type: (Object.prototype.hasOwnProperty.call(node.lineHeight, 'value') ? 'number' : 'string') as PropertyType
       },
       paragraphIndent: {

diff --git a/tests/unit/exportRawTokenArray.test.ts b/tests/unit/exportRawTokenArray.test.ts
@@ -158,6 +158,6 @@ describe('exportRawTokenArray', () => {
       }
     ]
     // @ts-ignore
-    expect(exportRawTokenArray('', defaultSettings)).toStrictEqual(output)
+    expect(exportRawTokenArray('', { ...defaultSettings, ...{ exclusionPrefix: '*' } })).toStrictEqual(output)
   })
 })
diff --git a/tests/unit/filterByNameProperty.test.ts b/tests/unit/filterByNameProperty.test.ts
@@ -1,7 +1,7 @@
 import filterByNameProperty from '../../src/utilities/filterByNameProperty'
 
 describe('getTokenStyles', () => {
-  test('exclude _ prefix', () => {
+  test('exclude _ . and * prefix', () => {
     expect([
       {
         id: 'valid',
@@ -20,6 +20,12 @@ describe('getTokenStyles', () => {
         type: 'PAINT',
         name: '.invalid',
         description: ''
+      },
+      {
+        id: 'invalid',
+        type: 'PAINT',
+        name: '*invalid',
+        description: ''
       }
     ].filter(item => filterByNameProperty(item, ['*']))).toStrictEqual([
       {