Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Fix session update #1601

Merged
merged 1 commit into from
Mar 3, 2025
Merged

🐛 Fix session update #1601

merged 1 commit into from
Mar 3, 2025

Conversation

lukevella
Copy link
Owner

@lukevella lukevella commented Mar 3, 2025

Summary by CodeRabbit

  • New Features

    • User sessions now include enhanced profile information—name, email, and profile image—for a more personalized authentication experience.
  • Refactor

    • Streamlined the handling and validation of user session data to ensure improved consistency and reliability across the system.

Copy link

vercel bot commented Mar 3, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
app ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 3, 2025 2:08pm
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
landing ⬜️ Skipped (Inspect) Mar 3, 2025 2:08pm

Copy link
Contributor

coderabbitai bot commented Mar 3, 2025

Warning

Rate limit exceeded

@lukevella has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 23 minutes and 3 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

📥 Commits

Reviewing files that changed from the base of the PR and between 6733df9 and f56937b.

📒 Files selected for processing (1)
  • apps/web/src/next-auth.ts (2 hunks)

Walkthrough

This change updates the session handling logic in the authentication module by extending the session schema to include additional nullable fields: name, email, and image. The jwt callback function is revised to remove the trigger parameter and perform explicit assignments of these fields after schema validation, ensuring the token is enriched with the new session-based data.

Changes

Files Change Summary
apps/web/src/next-auth.ts Updated sessionUpdateSchema to include nullable name, email, and image fields. Modified jwt callback to remove the trigger parameter, and perform explicit assignments for name, email, and image (with image also assigned to token.picture) after session validation.

Sequence Diagram(s)

sequenceDiagram
    participant Client
    participant NextAuth
    participant Validator
    participant Token

    Client->>NextAuth: Send authentication request with session data
    NextAuth->>Validator: Validate session (name, email, image)
    Validator-->>NextAuth: Return validated session info
    NextAuth->>Token: Explicitly assign name, email, image to token (picture set from image)
    Token-->>Client: Return enriched token
Loading

Possibly related PRs

Poem

I'm a little rabbit, quick on my feet,
Hop-ping through code, making sessions neat.
With tokens full of names, emails, and pics,
The auth now dances, with some neat tricks!
Carrots and code, a joyous blend –
Updates complete, let the bugs now end!
🥕🐇 Happy coding, my dear friend!


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (1)
apps/web/src/next-auth.ts (1)

147-155: Consider documenting the image-to-picture mapping for clarity

The code now assigns data.image to token.picture, using different property names between the session schema and token. While this follows NextAuth conventions (where "picture" is the standard field for avatars), a brief comment would help future developers understand this intentional mapping.

 const { data } = parsed;
 token.name = data.name;
 token.email = data.email;
+// Map image field from session to picture field expected by NextAuth
 token.picture = data.image;
 token.timeFormat = data.timeFormat;
📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 83bf083 and 6733df9.

📒 Files selected for processing (1)
  • apps/web/src/next-auth.ts (3 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (4)
  • GitHub Check: Unit tests
  • GitHub Check: Integration tests
  • GitHub Check: Linting
  • GitHub Check: Type check
🔇 Additional comments (5)
apps/web/src/next-auth.ts (5)

20-28: Schema extension looks good!

The expansion of the sessionUpdateSchema to include name, email, and image as nullable fields makes sense, allowing the session to store additional user profile information.


143-144: Simplified callback parameter handling

This updated approach to check for the presence of session directly, rather than checking for a specific trigger value, simplifies the logic and makes the code more maintainable.


174-174: Good addition of image field to database query

Selecting the image field in the database query ensures consistent user data availability, matching the updated schema.


181-181: Consistent token update for user picture

This assignment correctly maps the database image field to the token's picture field, maintaining consistency with the session update logic above.


147-154: Improved explicit assignment approach

The direct assignment of each field from the parsed data to the token is clearer and less error-prone than iterating over entries. This approach makes it immediately obvious which session fields are being mapped to which token fields.

@lukevella lukevella force-pushed the fix-avatar-removal branch from 0f6d8ba to f56937b Compare March 3, 2025 14:02
@vercel vercel bot temporarily deployed to Preview – landing March 3, 2025 14:02 Inactive
@lukevella lukevella enabled auto-merge (squash) March 3, 2025 14:06
@lukevella lukevella merged commit b6fc95b into main Mar 3, 2025
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant