Rework more tests #578
Merged
Rework more tests #578
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rpauszek
requested review from
dean0x7d and
JoepVanlier
and removed request for
a team
rpauszek
force-pushed
the
rework_more_tests
branch
from
f5c5bbd to
196818b
Compare
rpauszek
force-pushed
the
rework_plotting_tests
branch
2 times, most recently
from
0d87195 to
8f62a18
Compare
rpauszek
force-pushed
the
rework_more_tests
branch
from
196818b to
e3de440
Compare
rpauszek
force-pushed
the
rework_plotting_tests
branch
from
8f62a18 to
95c0306
Compare
rpauszek
force-pushed
the
rework_more_tests
branch
from
e3de440 to
a66ed27
Compare
JoepVanlier
requested changes
Nov 3, 2023
| assert sliced.get_image("red").shape == (ref_pixels, ref_lines) | ||
| np.testing.assert_allclose(sliced.get_image("red").data, ref.image[:, :, 0]) | ||
|
|
||
| factor = 2 |
There was a problem hiding this comment.
nitpick: num_lines? (factor makes me think of jumping/striding)
| assert sliced.get_image("red").shape == (ref_pixels, 3) | ||
| np.testing.assert_allclose(sliced.get_image("red").data, ref.image[:, :3, 0]) | ||
|
|
||
| sliced = kymo["3.5s":"14s"] |
There was a problem hiding this comment.
Why go back to seconds here rather than something expressed in line times and whatnot?
Comment on lines
170
to
177
| # Test cropping in base pairs | ||
| kymo_bp = kymo.calibrate_to_kbp(1.000) |
There was a problem hiding this comment.
I think it might make sense to split the bp ones off into their own test. Also because you essentially redefine px_size here.
Comment on lines
259
to
261
| print(kymo.get_image("red")) | ||
| print(cropped.get_image("red")) | ||
| print(twice_cropped.get_image("red")) |
rpauszek
force-pushed
the
rework_more_tests
branch
2 times, most recently
from
d8973e2 to
21eed94
Compare
rpauszek
force-pushed
the
rework_more_tests
branch
from
21eed94 to
7733cb6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this PR?
Continuing from #577 , all kymo tests dealing with slicing/cropping
I left things as separate commits to hopefully make reviewing easier. Before merge, will squash with a proper commit message