feat(socket): work without luasocket, using luasystem instead #171
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
All we need for the core scheduling tasks is: - a `sleep` function for a non-busy-loop wait - a `gettime` function to get actual time at usecond So without using sockets, luasystem should be good enough. Removing LuaSOcket from the rockspec is a breaking change, hence it is still installed by default. To be reviewed in a next major.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All we need for the core scheduling tasks is:
sleepfunction for a non-busy-loop waitgettimefunction to get actual time at usecondSo without using sockets, luasystem should be good enough. Removing LuaSOcket from the rockspec is a breaking change, hence it is still installed by default. To be reviewed in a next major.