Upgrade to Node 22.13.1 in CI

[jstasiak]

Node 16 has been unmaintained for a long time[1]. Some of our dependencies stop being compatible with it, let's migrate to a newer engine to avoid problems.

22 because it's the current LTE line[1].

22.14.0 is out but not yet available on Docker Hub.

[1] https://nodejs.org/en/about/previous-releases

[raguiar9080]

IIRC the reason we chose Node 16 was to be as compatible with users as possible, considering we currently have some users using the library we might need to make sure this change works for them. At the bare minimum notify them of this upgrade seems critical 👍

[jstasiak]

ok that's a good point.

This change doesn't affect any user of this library, it just changes the CI setup. On the other hand it allows us to stop being compatible with Node 16 (or anything lower than 22 for that matter) without knowing that this happened.

if this upgrade seems critical

Not critical, just (un)blocking some improvements like #764

Have we made any promises regarding compatibility? Because I'd be tempted to just bump the major version of the library and document "it may run on older Node versions but we only test 20.x" or something.

Would bumping this to 18.x or 20.x be better in your opinion?

[raguiar9080]

if this upgrade seems critical

Not critical, just (un)blocking some improvements like #764

I really did meant just letting them know 'of' the upgrade seems critical 👍 As in, bare minimum we should let them know that future versions might not work on node 16 is my point.

Have we made any promises regarding compatibility? Because I'd be tempted to just bump the major version of the library and document "it may run on older Node versions but we only test 20.x" or something.

Would bumping this to 18.x or 20.x be better in your opinion?

I don't think we've made any promises regarding compatibility tbh. I agree with you that adding the 'it may run on older Node versions' is enough. At the end of the day it's a balance, we can't really support all the node versions that exist. As long as we're transparent what version we use for building/testing I think it's fine.

And regarding bumping to only 18.x or 20.x, I'm really unsure. It definitely feels that if we're bumping the version at some point we might as well go as much as possible to be stable for longer. But I don't really mind either way, again it's a balance.

[jstasiak]

We could have multiple CI workflows for multiple Node versions, could be useful to avoid regressions.

[rbruggem]

Would we need to bump the major version?

[jstasiak]

Would we need to bump the major version?

For this change? Not really, it doesn't affect anyone directly.

[jstasiak]

With the above in mind I'll close this PR and create a different one with an upgrade to Node 18 to stay as compatible as possible (I'd repurpose this PR but that would invalidate the discussion we had above).

[jstasiak]

#836 upgrades us to Node 18.