Fix case where query parameters are not added #61
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've introduced query parameters in the generator by adding them as normal parameters in the request body for our users. This was done by simply pushing these parameters to the
data
field the users use to send the necessary data to the endpoint.However, there was an edge case. Since we first process the query params and then the requestBody, for cases where the requestBody was a
anyOf
/allOf
we were fully substituting the parameters to be the requestBody, overwriting the query parameters that were previously added. To fix this, simply inverse the order of operations, first add the requestBody to the parameters and then process query parameters. This made some existing tests change the order of the parameters inside the object but resulting in the same data in the end.