Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate to Rokit as toolchain manager #238

Merged
merged 7 commits into from
Oct 16, 2024
Merged

Migrate to Rokit as toolchain manager #238

merged 7 commits into from
Oct 16, 2024

Conversation

CompeyDev
Copy link
Contributor

This PR migrates from an Aftman manifest to a Rokit manifest and utilizes setup-rokit in actions instead of setup-aftman.

It also moves just into a managed toolchain instead of a global installation using setup-just.

filiptibell
filiptibell approved these changes Oct 16, 2024
View reviewed changes
Copy link
Collaborator

@filiptibell filiptibell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is ready to be merged now. Rokit has been stable for a while and has had no critical issues.

Migrating just was a good call as well!

@filiptibell filiptibell merged commit eaac9ff into lune-org:main Oct 16, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@filiptibell filiptibell filiptibell approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@CompeyDev @filiptibell