refactor(benchmark): Adds sanitiseVersion function #340
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a minimal sanitization for passing a
versioncommand line argument to the benchmark suite.As it is now users get a random error back (
SyntaxError: Unexpected identifier 'find') when passing a unexpected/malformed version argument.With this change this added function throws an error when it doesn't receive the RegExp we're expecting as an argument, including a little bit more information.
The second commit only changes a variable's name; feel free to trim it. 😊
This PR also replaces #337 since I had included commits that were not supposed to be included.