nshlib/cmd_cat: Avoid casting -1 to size_t as count of nsh_write()

Signed-off-by: wangjianyu3 <[email protected]>
lupyuen2 · Oct 17, 2024 · c5c18a2 · c5c18a2
1 parent cb24b74
commit c5c18a2
Showing 1 changed file with 6 additions and 5 deletions.
diff --git a/nshlib/nsh_fscmds.c b/nshlib/nsh_fscmds.c
@@ -801,12 +801,13 @@ int cmd_cat(FAR struct nsh_vtbl_s *vtbl, int argc, FAR char **argv)
 
       while (true)
         {
-          ssize_t n = nsh_read(vtbl, buf, BUFSIZ);
-
-          if (n == 0)
-            break;
+          ret = nsh_read(vtbl, buf, BUFSIZ);
+          if (ret <= 0)
+            {
+              break;
+            }
 
-          nsh_write(vtbl, buf, n);
+          nsh_write(vtbl, buf, ret);
         }
 
       free(buf);