chore: use RawPtr::Env to signal raw pointers for environments
#1203
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arthurpaulino
force-pushed
the
ap/raw-ptr-env
branch
2 times, most recently
from
f1be69f to
94c18a8
Compare
arthurpaulino
force-pushed
the
ap/raw-ptr-env
branch
from
94c18a8 to
f4d3a5c
Compare
gabriel-barrett
suggested changes
Mar 8, 2024
There was a problem hiding this comment.
I understand the concern, but this is mixing the concepts of the raw pointer and the pointer. The raw pointer is supposed to only give information on the number of children it has. The pointer, then, gives the layout, with the tag. I think that the correct approach is actually restructuring the zstore, since we do not assume all children are always pointers anymore. This is why I'm blocking this PR for now
|
Closing in favor of #1221 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's safer to use a new variant
RawPtr::Envto signal raw pointers for environments than relying solely on tag checks. This would probably have avoided the bug introduced in #1183, whose fix was implemented in #1200