V3 Replay node in NN build methods #1214
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
moratom
approved these changes
Jan 29, 2025
asahtik
reviewed
Jan 30, 2025
| @@ -85,6 +85,24 @@ void bind_neuralnetwork(pybind11::module& m, void* pCallstack) { | |||
| py::arg("model"), | |||
| py::arg("fps") = 30.0f, | |||
| DOC(dai, node, NeuralNetwork, build)) | |||
| .def( | |||
| "build", | |||
| [](NeuralNetwork& self, const std::shared_ptr<ReplayVideo>& input, const dai::NNArchive& nnArchive, float fps) { | |||
There was a problem hiding this comment.
Use py::overload_cast<const std::shared_ptr<ReplayVideo>&, const dai::NNArchive&, float>(&NeuralNetwork::build) instead of lambda for consistency
asahtik
reviewed
Jan 30, 2025
moratom
reviewed
Feb 4, 2025
There was a problem hiding this comment.
The example workss cross platform, so it can be moved to "DetectionNetwork" folder IMO
There was a problem hiding this comment.
And for CPP to HostNodes?
There was a problem hiding this comment.
I think we can make the same one in DetectionNetwork (note I renamed the example a bit to be consistent with the other ones in the folder and added it to tests).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds new overloads for build methods in NN, Detections and SpatialDetection nodes. Also some cosmetic changes