Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ImageManipV2 RAW16 support #1221

Merged
merged 16 commits into from
Jan 29, 2025
Merged

ImageManipV2 RAW16 support #1221

merged 16 commits into from
Jan 29, 2025

Conversation

asahtik
Copy link
Contributor

@asahtik asahtik commented Jan 24, 2025

No description provided.

@asahtik asahtik requested a review from moratom January 24, 2025 16:10
Copy link
Collaborator

@moratom moratom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (left one question though)

And let's just add a quick test before merging, thanks!

Comment on lines 3465 to 3468
case ImgFrame::Type::RAW16:
backgroundColor[0] = r;
backgroundColor[1] = g;
break;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this make sense?

@moratom moratom merged commit 706678e into v3_develop Jan 29, 2025
42 of 45 checks passed
@moratom moratom deleted the imagemanipv2_raw16_support branch January 29, 2025 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants