Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix COCO Parser Splits #100

Merged
merged 3 commits into from
Apr 6, 2024
Merged

Fix COCO Parser Splits #100

merged 3 commits into from
Apr 6, 2024

Conversation

sokovninn
Copy link
Member

The PR includes:

  • Fixed the order of val and test in the BaseParser.
  • Fixed overriding test images with an empty list in the COCOParser.

@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 5, 2024

Test Results

53 tests  ±0   53 ✅ ±0   58s ⏱️ +11s
 1 suites ±0    0 💤 ±0 
 1 files   ±0    0 ❌ ±0 

Results for commit ae8dc29. ± Comparison against base commit eb5c61d.

@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 5, 2024

☂️ Python Coverage

current status: ✅

Overall Coverage

Lines Covered Coverage Threshold Status
3358 2216 66% 0% 🟢

New Files

No new covered files...

Modified Files

File Coverage Status
luxonis_ml/data/parsers/base_parser.py 90% 🟢
luxonis_ml/data/parsers/coco_parser.py 80% 🟢
TOTAL 85% 🟢

updated for commit: ae8dc29 by action🐍

kozlov721
kozlov721 approved these changes Apr 6, 2024
View reviewed changes
Copy link
Collaborator

@kozlov721 kozlov721 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sokovninn sokovninn merged commit ecd94a9 into dev Apr 6, 2024
12 checks passed
@kozlov721 kozlov721 deleted the fix/coco-parser-splits branch July 2, 2024 04:26
@kozlov721 kozlov721 added fix Fixing a bug data Changes affecting luxonis_ml.data subpackage labels Jul 31, 2024
@kozlov721 kozlov721 changed the title Fix/coco parser splits Fix COCO Parser Splits Jul 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@conorsim conorsim conorsim approved these changes

@kozlov721 kozlov721 kozlov721 approved these changes

@tersekmatija tersekmatija Awaiting requested review from tersekmatija

Assignees

@sokovninn sokovninn

Labels
data Changes affecting luxonis_ml.data subpackage fix Fixing a bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sokovninn @kozlov721 @conorsim