Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix augmented loader with no labels #202

Merged
merged 2 commits into from
Nov 6, 2024
Merged

Conversation

kozlov721
Copy link
Collaborator

  • Fixed a bug when LuxonisLoader was failing for datasets with no labels when used with augmentations
  • Added tests for this use case
  • Improved an error message for when user tries to load an empty dataset / view

@kozlov721 kozlov721 requested a review from a team as a code owner November 5, 2024 18:42
@kozlov721 kozlov721 requested review from klemen1999, tersekmatija and conorsim and removed request for a team November 5, 2024 18:42
@github-actions github-actions bot added the fix Fixing a bug label Nov 5, 2024
@kozlov721 kozlov721 changed the title Fix/no images augmentations Fix augmented loader with no labels Nov 5, 2024
Copy link

codecov bot commented Nov 5, 2024

Codecov Report

Attention: Patch coverage is 94.44444% with 1 line in your changes missing coverage. Please review.

Project coverage is 92.53%. Comparing base (6bcbb11) to head (cb823f8).
Report is 13 commits behind head on main.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
luxonis_ml/data/loaders/luxonis_loader.py 80.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #202      +/-   ##
==========================================
+ Coverage   92.33%   92.53%   +0.19%     
==========================================
  Files          79       80       +1     
  Lines        4161     4245      +84     
==========================================
+ Hits         3842     3928      +86     
+ Misses        319      317       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sokovninn sokovninn merged commit 32238bd into main Nov 6, 2024
12 checks passed
@sokovninn sokovninn deleted the fix/no-images-augmentations branch November 6, 2024 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix Fixing a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants