Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default empty task name #222

Merged
merged 13 commits into from
Jan 14, 2025
Merged

Default empty task name #222

merged 13 commits into from
Jan 14, 2025

Conversation

kozlov721
Copy link
Collaborator

Changed the default task_name from "detection" to an empty string. "detection" can be confusing for example for semantic segmentation tasks and there's not a reason to have any task name for datasets with only one task.

@kozlov721 kozlov721 requested a review from a team as a code owner January 14, 2025 09:36
@kozlov721 kozlov721 requested review from klemen1999, tersekmatija and conorsim and removed request for a team January 14, 2025 09:36
@github-actions github-actions bot added the enhancement New feature or request label Jan 14, 2025
Copy link
Collaborator

@klemen1999 klemen1999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just needs fixing of tests

Copy link

codecov bot commented Jan 14, 2025

Codecov Report

Attention: Patch coverage is 96.29630% with 1 line in your changes missing coverage. Please review.

Project coverage is 95.92%. Comparing base (539fde4) to head (4eabba5).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
luxonis_ml/data/parsers/base_parser.py 92.85% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##           main     #222       +/-   ##
=========================================
+ Coverage      0   95.92%   +95.92%     
=========================================
  Files         0       88       +88     
  Lines         0     4737     +4737     
=========================================
+ Hits          0     4544     +4544     
- Misses        0      193      +193     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kozlov721 kozlov721 merged commit d2840b2 into main Jan 14, 2025
12 checks passed
@kozlov721 kozlov721 deleted the feature/task-name branch January 14, 2025 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants