-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes for nested labels #224
Conversation
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found.
Additional details and impacted files@@ Coverage Diff @@
## main #224 +/- ##
==========================================
- Coverage 95.93% 95.86% -0.07%
==========================================
Files 88 89 +1
Lines 4744 4715 -29
==========================================
- Hits 4551 4520 -31
- Misses 193 195 +2 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, left one comment regarding tests
BaseDataset.get_tasks
to a dictionary mapping task names to task types (before it was just a list of combined task names)BaseDataset.get_classes
from a tuple of all classes and a dictionary mapping task names to classes to just the later. The list of all classes doesn't make semantic sense with the new tasks, and also it was rarely even used anywherecreated_at
timestamp from parquet files - wasn't used anywheretask_name
andtask_type
values for annotations with nested sub-detectionstask_name
instead oftask_type
{"car/driver": "boundingbox"}
instead of{"car": "driver/boundingbox"}