Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes for nested labels #224

Merged
merged 8 commits into from
Jan 16, 2025
Merged

Fixes for nested labels #224

merged 8 commits into from
Jan 16, 2025

Conversation

kozlov721
Copy link
Collaborator

@kozlov721 kozlov721 commented Jan 15, 2025

  • Changed return type of BaseDataset.get_tasks to a dictionary mapping task names to task types (before it was just a list of combined task names)
  • Changed return type of BaseDataset.get_classes from a tuple of all classes and a dictionary mapping task names to classes to just the later. The list of all classes doesn't make semantic sense with the new tasks, and also it was rarely even used anywhere
  • Removed the created_at timestamp from parquet files - wasn't used anywhere
  • Fixed task_name and task_type values for annotations with nested sub-detections
    • Names of the sub-detections are now part of the task_name instead of task_type
    • {"car/driver": "boundingbox"} instead of {"car": "driver/boundingbox"}
  • Added additional overloads to methods loading parquet files
  • Simplified some tests

@kozlov721 kozlov721 requested a review from a team as a code owner January 15, 2025 21:55
@kozlov721 kozlov721 requested review from klemen1999, tersekmatija and conorsim and removed request for a team January 15, 2025 21:55
@github-actions github-actions bot added fix Fixing a bug data Changes affecting luxonis_ml.data subpackage CLI Changes affecting the CLI labels Jan 15, 2025
Copy link

codecov bot commented Jan 16, 2025

Codecov Report

Attention: Patch coverage is 96.90722% with 3 lines in your changes missing coverage. Please review.

Project coverage is 95.86%. Comparing base (2fbec83) to head (37fed81).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
luxonis_ml/data/datasets/luxonis_dataset.py 88.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #224      +/-   ##
==========================================
- Coverage   95.93%   95.86%   -0.07%     
==========================================
  Files          88       89       +1     
  Lines        4744     4715      -29     
==========================================
- Hits         4551     4520      -31     
- Misses        193      195       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@klemen1999 klemen1999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, left one comment regarding tests

tests/test_data/test_dataset.py Show resolved Hide resolved
@kozlov721 kozlov721 merged commit c08bd5b into main Jan 16, 2025
12 checks passed
@kozlov721 kozlov721 deleted the fix/task-dictionary branch January 16, 2025 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLI Changes affecting the CLI data Changes affecting luxonis_ml.data subpackage fix Fixing a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants