Adding windows support to the python wrapper #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. Changed '/dev/null' to os.devnull 2. Fixed bhtsne.exe binary location
lvdmaaten
added a commit
that referenced
this pull request
Aug 21, 2015
Adding windows support to the python wrapper
|
Looks good to me, thanks! |
|
Hi, can we remove the os.fork() function to allow full compatibility with windows and jupyter? Please take a look at my code at #42 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I used BHtSNE quite a few times recently for a project, and I got the python wrapper to work on windows after making a couple of pretty simple changes. Thought I should submit a patch in case any one else wanted to use it on windows as well.