Skip to content

Commit

Permalink
Merge pull request #1403 from lwindolf/download-manager
Browse files Browse the repository at this point in the history 
#1388 Rewrite of plugin mgmt + new download manager
  • Loading branch information
@lwindolf
lwindolf authored Dec 30, 2024
2 parents 39ee8ac + 171033a commit e93fc53
Show file tree
Hide file tree
Showing 75 changed files with 10,205 additions and 10,325 deletions.
1 change: 1 addition & 0 deletions .gitignore
View file
Original file line number Diff line number Diff line change
Expand Up @@ -60,3 +60,4 @@ xslt/*.xml
org.gnome.liferea.gschema.valid
stamp-h1
.flatpak-builder
.vscode
9 changes: 9 additions & 0 deletions ChangeLog
View file
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,15 @@ To be released

* New unit tests for update handling code
(Lars Windolf)

* #1388 Implemented download manager plugin, all preferences
for external tools were dropped
(Lars Windolf)

* Refactoring of plugin management, code reorganized. Disabling plugins
now does not disable base plugins (needed for auth and node sources)
as this would prevent startup
(Lars Windolf)


2024-09-26 Lars Windolf <[email protected]>
Expand Down
3 changes: 3 additions & 0 deletions Makefile.am
View file
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,9 @@ plugin_DATA = \
plugins/add-bookmark-site.ui \
plugins/bold-unread.py \
plugins/bold-unread.plugin \
plugins/download-manager.py \
plugins/download-manager.plugin \
plugins/download-manager.ui \
plugins/getfocus.py \
plugins/getfocus.plugin \
plugins/gnome-keyring.py \
Expand Down
9 changes: 5 additions & 4 deletions configure.ac
View file
Original file line number Diff line number Diff line change
Expand Up @@ -87,13 +87,14 @@ AC_CONFIG_FILES([
Makefile
net.sf.liferea.gschema.xml
src/Makefile
src/webkit/Makefile
src/webkit/web_extension/Makefile
src/parsers/Makefile
src/node_providers/Makefile
src/node_sources/Makefile
src/ui/Makefile
src/parsers/Makefile
src/plugins/Makefile
src/tests/Makefile
src/ui/Makefile
src/webkit/Makefile
src/webkit/web_extension/Makefile
doc/Makefile
doc/html/Makefile
xslt/Makefile
Expand Down
162 changes: 0 additions & 162 deletions glade/prefs.ui
View file
Original file line number Diff line number Diff line change
Expand Up @@ -1833,168 +1833,6 @@
<property name="tab-fill">False</property>
</packing>
</child>
<child>
<!-- n-columns=1 n-rows=1 -->
<object class="GtkGrid" id="enclosuresPage">
<property name="visible">True</property>
<property name="can-focus">False</property>
<property name="border-width">12</property>
<property name="row-spacing">18</property>
<child>
<!-- n-columns=3 n-rows=3 -->
<object class="GtkGrid" id="downloadingEnclosuresGrid">
<property name="visible">True</property>
<property name="can-focus">False</property>
<property name="row-spacing">6</property>
<property name="column-spacing">12</property>
<child>
<object class="GtkLabel" id="downloadingEnclosuresLabel">
<property name="visible">True</property>
<property name="can-focus">False</property>
<property name="label" translatable="yes">Downloading Content</property>
<property name="xalign">0</property>
<attributes>
<attribute name="weight" value="bold"/>
</attributes>
<accessibility>
<relation type="label-for" target="downloadingEnclosuresGrid"/>
</accessibility>
</object>
<packing>
<property name="left-attach">0</property>
<property name="top-attach">0</property>
<property name="width">3</property>
</packing>
</child>
<child>
<object class="GtkLabel" id="downloadToolComboLabel">
<property name="visible">True</property>
<property name="can-focus">False</property>
<property name="margin-start">12</property>
<property name="label" translatable="yes">_Download using</property>
<property name="use-underline">True</property>
<property name="mnemonic-widget">predefinedDownload</property>
<property name="xalign">0</property>
<accessibility>
<relation type="label-for" target="downloadToolCombo"/>
</accessibility>
</object>
<packing>
<property name="left-attach">0</property>
<property name="top-attach">1</property>
</packing>
</child>
<child>
<object class="GtkRadioButton" id="predefinedDownload">
<property name="visible">True</property>
<property name="can-focus">True</property>
<property name="receives-default">False</property>
<property name="active">True</property>
<property name="draw-indicator">True</property>
<signal name="toggled" handler="on_enclosure_download_predefined_toggled" swapped="no"/>
<child>
<placeholder/>
</child>
</object>
<packing>
<property name="left-attach">1</property>
<property name="top-attach">1</property>
</packing>
</child>
<child>
<object class="GtkRadioButton" id="customDownload">
<property name="visible">True</property>
<property name="can-focus">True</property>
<property name="receives-default">False</property>
<property name="active">True</property>
<property name="draw-indicator">True</property>
<property name="group">predefinedDownload</property>
<child>
<placeholder/>
</child>
</object>
<packing>
<property name="left-attach">1</property>
<property name="top-attach">2</property>
</packing>
</child>
<child>
<object class="GtkLabel" id="customDownloadEntryLabel">
<property name="visible">True</property>
<property name="can-focus">False</property>
<property name="label" translatable="yes">&lt;small&gt;(%s for URL)&lt;/small&gt;</property>
<property name="use-markup">True</property>
<property name="use-underline">True</property>
<property name="mnemonic-widget">customDownload</property>
<property name="xalign">1</property>
<accessibility>
<relation type="label-for" target="customDownloadEntry"/>
</accessibility>
</object>
<packing>
<property name="left-attach">0</property>
<property name="top-attach">2</property>
</packing>
</child>
<child>
<object class="GtkComboBox" id="downloadToolCombo">
<property name="visible">True</property>
<property name="can-focus">False</property>
<child>
<object class="GtkCellRendererText" id="cellrenderertext1"/>
<attributes>
<attribute name="text">0</attribute>
</attributes>
</child>
<accessibility>
<relation type="labelled-by" target="downloadToolComboLabel"/>
</accessibility>
</object>
<packing>
<property name="left-attach">2</property>
<property name="top-attach">1</property>
</packing>
</child>
<child>
<object class="GtkEntry" id="customDownloadEntry">
<property name="visible">True</property>
<property name="can-focus">True</property>
<property name="placeholder-text" translatable="yes">custom-command %s</property>
<signal name="changed" handler="on_enclosure_download_custom_command_changed" swapped="no"/>
<accessibility>
<relation type="labelled-by" target="customDownloadEntryLabel"/>
</accessibility>
</object>
<packing>
<property name="left-attach">2</property>
<property name="top-attach">2</property>
</packing>
</child>
<accessibility>
<relation type="labelled-by" target="downloadingEnclosuresLabel"/>
</accessibility>
</object>
<packing>
<property name="left-attach">0</property>
<property name="top-attach">0</property>
</packing>
</child>
</object>
<packing>
<property name="position">7</property>
</packing>
</child>
<child type="tab">
<object class="GtkLabel">
<property name="visible">True</property>
<property name="can-focus">False</property>
<property name="label" translatable="yes">Download</property>
</object>
<packing>
<property name="position">7</property>
<property name="tab-fill">False</property>
</packing>
</child>
</object>
<packing>
<property name="expand">False</property>
Expand Down
14 changes: 14 additions & 0 deletions plugins/download-manager.plugin
View file
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
[Plugin]
Loader=python3
Module=download-manager
IAge=3
Name=Download Manager
Name[de]=Download Manager
Description=Allows downloading multiple files concurrently
Description[de]=Einfaches Downloaden mehrerer Dateien
Builtin=true
Icon=emblem-default
Authors=Lars Windolf <[email protected]>
Copyright=Copyright © 2024 Lars Windolf
Website=https://github.com/lwindolf/liferea
Version=0.1.0
Loading

0 comments on commit e93fc53

Please sign in to comment.