Implement four out of five suggested optimizations #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #27
The remaining suggestion requires understanding where a label point to so that it can be replaced by its literal equivalent. See #36.
Hopefully I didn't get anything wrong here.
I have verified the optimizations within
oneko-uxn, and verified it works still.The change isn't anything to write home about, but still interesting.
61073 bytes → 60980 bytesI suspect #36 might boil down to interesting numbers though.
(I had observed something "going wrong", but it was unrelated, and the optimizations of my wrong use of the semantics around the calling convention in
asm()was at fault, and failing otherwisely without these additional optimizations. It would be wise to validate carefully.)