Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add speak_sd example for issue #149 #151

Merged
merged 2 commits into from
Jul 2, 2024
Merged

Add speak_sd example for issue #149 #151

merged 2 commits into from
Jul 2, 2024

Conversation

GOB52
Copy link
Contributor

@GOB52 GOB52 commented May 23, 2024

Added example for Issue #149.
It reads a wav file from an SD card and plays it back.

@Tinyu-Zhao
Copy link
Collaborator

Tinyu-Zhao commented Jul 1, 2024

I think you can put the file speak_sd.wav into the example folded so that users can use the example faster. Otherwise, you may need to find a suitable wav file, which will take some time.

@GOB52
Copy link
Contributor Author

GOB52 commented Jul 1, 2024

I think you can put the file speak_sd.wav into the example folded so that users can use the example faster. Otherwise, you may need to find a suitable wav file, which will take some time.

Does M5 have sound data without rights issues?
If you have it, I will process it, but if not, I will look for CC0 etc.

@Tinyu-Zhao
Copy link
Collaborator

I think you can put the file speak_sd.wav into the example folded so that users can use the example faster. Otherwise, you may need to find a suitable wav file, which will take some time.

Does M5 have sound data without rights issues? If you have it, I will process it, but if not, I will look for CC0 etc.

I think I can’t find audio files without copyright issues at the moment. 😂

@GOB52
Copy link
Contributor Author

GOB52 commented Jul 1, 2024

I think I can’t find audio files without copyright issues at the moment. 😂

OK, I will find a file with no rights issues.

@GOB52
Copy link
Contributor Author

GOB52 commented Jul 1, 2024

Resource data, I think it would be better to create a Github Wiki page and upload it there than to put it in a repository.
How about it?

@Tinyu-Zhao
Copy link
Collaborator

Resource data, I think it would be better to create a Github Wiki page and upload it there than to put it in a repository. How about it?

I think it's okay, it doesn't have to be placed in the main warehouse, maybe other programs will reuse it.

@GOB52
Copy link
Contributor Author

GOB52 commented Jul 1, 2024

Created and uploaded wav to GitHub wiki.
Fixes example source code.

@Tinyu-Zhao
Copy link
Collaborator

I think this is perfect, thanks for the PR.

@Tinyu-Zhao Tinyu-Zhao merged commit 544883b into master Jul 2, 2024
2 of 4 checks passed
@Cupcc
Copy link

Cupcc commented Aug 8, 2024

why the display filled with purple color after I uploaded this file?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants