Routes query v3 #490
Open
Routes query v3 #490
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
konker
commented
May 25, 2020
maas-schemas/schemas/maas-backend/routes/routes-query/request.json
Outdated
Show resolved
Hide resolved
thanhtr
force-pushed
the
routes-query-v3
branch
2 times, most recently
from
f3113c1
to
9bcddf5
Compare
hieuunguyeen
reviewed
Jun 1, 2020
| { "$ref": "http://maasglobal.com/core/components/units.json#/definitions/uuid" }, | ||
| { | ||
| "type": "string", | ||
| "enum": ["UNKNOWN"] |
There was a problem hiding this comment.
If not available, isn't it made more sense just being null?
There was a problem hiding this comment.
In this way there is a clear indication that the routes query was executed without a requestId, and is soemthing positive to base other things on, e.g. searching logs for bad requests to omit them from further use.
There was a problem hiding this comment.
I'd still suggest using null. Null is very clear, comparing to what you think about "undefined"
| @@ -64,6 +64,12 @@ | |||
| "agencyId": { | |||
| "$ref": "http://maasglobal.com/core/components/common.json#/definitions/agencyId" | |||
| }, | |||
| "agencyName": { | |||
There was a problem hiding this comment.
I assume this is the provider that provided the route?
maas-schemas/schemas/maas-backend/routes/routes-query/request.json
Outdated
Show resolved
Hide resolved
thanhtr
force-pushed
the
routes-query-v3
branch
2 times, most recently
from
4046b0a
to
e3c5d1b
Compare
thanhtr
force-pushed
the
routes-query-v3
branch
from
22dc9a3
to
0260bc3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What has been implemented?
Mainly extra itinerary properties to support routes-query-v3 (used for Whim Ride)
Todos:
Versioning: