Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

R: updates for packages #24888

Merged
merged 19 commits into from
Jul 15, 2024
Merged

R: updates for packages #24888

merged 19 commits into from
Jul 15, 2024

Conversation

barracuda156
Copy link
Contributor

@barracuda156 barracuda156 commented Jul 12, 2024 •
edited
Loading

Description

Updates

Type(s)
  • bugfix
  • enhancement
  • security fix
Tested on

macOS 10.6
Xcode 3.2

Verification

Have you

  • followed our Commit Message Guidelines?
  • squashed and minimized your commits?
  • checked that there aren't other open pull requests for the same change?
  • referenced existing tickets on Trac with full URL in commit message?
  • checked your Portfile with port lint --nitpick?
  • tried existing tests with sudo port test? (where tests are added)
  • tried a full install with sudo port -vst install?
  • tested basic functionality of all binary files?
  • checked that the Portfile's most important variants haven't been broken?

reneeotten
reneeotten reviewed Jul 13, 2024
View reviewed changes
R/R-BayesianNetwork/Portfile
maintainers {@barracuda156 gmail.com:vital.had} openmaintainer
license {Apache-1.1 Apache-2}
license Apache
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

from upstream's GitHub it appears the license is Apache-2

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/paulgovan/BayesianNetwork/blob/ba31a3b844f0229542efa5a5f948fa612b4e91d0/DESCRIPTION#L12

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

well, how did you decide which was is correct if there is a discrepancy between that file and the LICENSE file? It's either Apache, which for MacPorts means version 1 or Apache-2. Please clarify with upstream

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I take DESCRIPTION as a statement for official purposes, since that file is parsed by CRAN, and license there is set accordingly.
But this is not something I really care about. I am totally okay setting it to Apache-2.

@barracuda156
Copy link
Contributor Author

@reneeotten If I get a reply, I will update the license, if needed: paulgovan/BayesianNetwork#21
For now, follow CRAN.

@reneeotten reneeotten merged commit 8b91359 into macports:master Jul 15, 2024
3 checks passed
@barracuda156 barracuda156 deleted the rupd branch July 15, 2024 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@reneeotten reneeotten reneeotten left review comments

Assignees
No one assigned
Labels
maintainer: open Affects an openmaintainer port maintainer type: update
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@barracuda156 @reneeotten @macportsbot