Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ansible, ansible-core and ansible-compat to latest versions #27148

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

jhoyt4
Copy link
Contributor

@jhoyt4 jhoyt4 commented Dec 20, 2024

Description

Update ansible to 11.1.0, add python313
ansible-core to 2.18.1, remove defunct ansible-connect, add python 313
ansible-compat to 24.10.0, update download name, add python313
ansible-select: remove defunct ansible-connect

py-bcrypt, py-httplib2, py-paramiko, py-resolvelib,py-subprocess-tee
Update to python 3.13 and update where appropriate

  • py-bcrypt: update to 4.2.1, update related cargo modules
    add python 3.13, add patch to remove uppoer version boundary of py-setuptools (75.8.0)
  • py-httplib2: add python 3.13
  • py-paramiko: update to 3.5.0 add python 3.13
  • py-pynacl: add python 3.13
  • py-resolvelib: update to 1.1.0 add python 3.13
  • py-subprocess-tee: update to 0.4.2 add python 3.13
Type(s)
  • bugfix
  • enhancement
  • security fix
Tested on

macOS 15.1.1 24B91 arm64
Xcode 16.2 16C5032a

Verification

Have you

  • followed our Commit Message Guidelines?
  • squashed and minimized your commits?
  • checked that there aren't other open pull requests for the same change?
  • referenced existing tickets on Trac with full URL in commit message? (No tickets open)
  • checked your Portfile with port lint?
  • tried existing tests with sudo port test?
  • tried a full install with sudo port -vst install?
  • tested basic functionality of all binary files?
  • checked that the Portfile's most important variants haven't been broken?

@macportsbot
Copy link

Notifying maintainers:
@adfernandes for port py-ansible-core, py-ansible.
@stromnov for port py-bcrypt, py-paramiko, py-pynacl.
@lpsinger for port py-httplib2.
@judaew for port py-ansible-compat, py-subprocess-tee.
@steenzout for port py-ansible-core, py-ansible.

@jhoyt4 jhoyt4 force-pushed the ansible branch 3 times, most recently from 33ae812 to 1e06f16 Compare December 20, 2024 20:14
@jhoyt4
Copy link
Contributor Author

jhoyt4 commented Dec 20, 2024

port lint is failing for py-bcrypt. This issue is unrelated to the update and was there before the change.

@mascguy
Copy link
Member

mascguy commented Dec 20, 2024

@mascguy - any reason you killed the macOS 15 CI?

Yes, because the macOS 15 builder often runs for 6 hours, at which point it's killed by GitHub. Though I'm happy to rerun that, if you think there's a chance it might succeed?

@mascguy
Copy link
Member

mascguy commented Dec 20, 2024

Restarted the macOS 15 build, let's see how it goes...

@mascguy
Copy link
Member

mascguy commented Dec 21, 2024

@mascguy - success! Thanks again for entertaining me.

Great, glad we reran it!

@ryandesign
Copy link
Contributor

the macOS 15 builder often runs for 6 hours

because it needs to build all dependencies because we don't have a macOS 15 arm64 buildbot worker yet. We should not have added macOS 15 to GitHub Actions CI without that in place.

@jhoyt4 jhoyt4 force-pushed the ansible branch 2 times, most recently from 115cf75 to 9494648 Compare December 28, 2024 00:54
@jhoyt4 jhoyt4 marked this pull request as draft December 28, 2024 13:49
@jhoyt4 jhoyt4 changed the title Update ansible, ansible-core and ansible-compat to latest versions WIP: Update ansible, ansible-core and ansible-compat to latest versions Dec 28, 2024
@jhoyt4 jhoyt4 changed the title WIP: Update ansible, ansible-core and ansible-compat to latest versions Update ansible, ansible-core and ansible-compat to latest versions Dec 28, 2024
@jhoyt4 jhoyt4 marked this pull request as ready for review December 28, 2024 14:38
@jhoyt4 jhoyt4 marked this pull request as draft December 28, 2024 14:41
@jhoyt4 jhoyt4 marked this pull request as ready for review December 28, 2024 15:10
@jhoyt4 jhoyt4 force-pushed the ansible branch 3 times, most recently from 9b805c3 to 2f4ea11 Compare January 11, 2025 20:15
Update to python 3.13 and update where appropriate

  - py-bcrypt: update to 4.2.1, update related cargo modules
               add python 3.13, remove python 37 and 38
  - py-httplib2: add python 3.13
  - py-paramiko: update to 3.5.0 add python 3.13
  - py-pynacl: add python 3.13
  - py-resolvelib: update to 1.1.0 add python 3.13
  - py-subprocess-tee: update to 0.4.2 add python 3.13
@jhoyt4
Copy link
Contributor Author

jhoyt4 commented Jan 11, 2025

@jmroot - The latest CI failure on this PR is due to py-setuptools being upgraded to 75.8.0.

The latest ansible-core wants setuptools<=75.6.0. The setuptools update might also break older ansible installs.

@jhoyt4 jhoyt4 marked this pull request as draft January 12, 2025 16:07
@jhoyt4 jhoyt4 changed the title Update ansible, ansible-core and ansible-compat to latest versions WIP: Update ansible, ansible-core and ansible-compat to latest versions Jan 12, 2025
@jmroot
Copy link
Member

jmroot commented Jan 13, 2025

I doubt there's any actual incompatibility between these setuptools versions. Ansible is just setting an upper bound (in pyproject.toml) of the latest version they tested with.

@jhoyt4 jhoyt4 changed the title WIP: Update ansible, ansible-core and ansible-compat to latest versions Update ansible, ansible-core and ansible-compat to latest versions Jan 14, 2025
@jhoyt4 jhoyt4 changed the title Update ansible, ansible-core and ansible-compat to latest versions WIP: Update ansible, ansible-core and ansible-compat to latest versions Jan 14, 2025
@jhoyt4
Copy link
Contributor Author

jhoyt4 commented Jan 14, 2025

@jmroot - do you know of a simple way to detect py-setuptools version? I hacked in a patch, but would prefer it to be less hard coded.

@jhoyt4 jhoyt4 changed the title WIP: Update ansible, ansible-core and ansible-compat to latest versions Update ansible, ansible-core and ansible-compat to latest versions Jan 15, 2025
@jhoyt4 jhoyt4 marked this pull request as ready for review January 15, 2025 00:32
@jhoyt4 jhoyt4 marked this pull request as draft January 15, 2025 00:44
@jmroot
Copy link
Member

jmroot commented Jan 15, 2025

@jmroot - do you know of a simple way to detect py-setuptools version? I hacked in a patch, but would prefer it to be less hard coded.

To remove the upper bound you can just remove the <= version entirely, e.g. change "setuptools >= 66.1.0, <= 75.6.0" to "setuptools >= 66.1.0". Then it will at least only break when there is an actual incompatibility, and not just when the version number exceeds an arbitrary limit…

@jhoyt4 jhoyt4 marked this pull request as ready for review January 15, 2025 11:07
to latest revs for python 3.13 support

  py-ansible:        upgrade to 11.1.0
                     add python313
                     patch to remove upper version boundary of
                       py-setuptools >75.6.0
  py-ansible-core:   upgrade to 2.18.1
                     add python313
                     remove defunct ansible-connection
  py-ansible-compat: upgrade to 24.10.0
                     add python313
                     correct download name and homepage
  ansible-select:    remove defunct ansible-connection
@jhoyt4
Copy link
Contributor Author

jhoyt4 commented Jan 16, 2025

That last force push should implement the suggested setuptools version edit and add a few lines to remove any sylink to ansible-connect-3XX now that it's been removed from ansible.

Assuming this passes CI, I'm hoping someone can either finally commit the PR or make suggestions on what needs to be done to get it approved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

9 participants