Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python314-devel: add compatibility patch to fix build on macOS <10.12 #27198

Conversation

aeiouaeiouaeiouaeiouaeiouaeiou
Copy link
Contributor

Closes: https://trac.macports.org/ticket/71608

Description

Type(s)
  • bugfix
  • enhancement
  • security fix
Tested on

macOS 10.6.8 10K549 x86_64
Xcode 4.2 4C199

Verification

Have you

  • followed our Commit Message Guidelines?
  • squashed and minimized your commits?
  • checked that there aren't other open pull requests for the same change?
  • referenced existing tickets on Trac with full URL in commit message?
  • checked your Portfile with port lint?
  • tried existing tests with sudo port test?
  • tried a full install with sudo port -vst install?
  • tested basic functionality of all binary files?
  • checked that the Portfile's most important variants haven't been broken?

@macportsbot
Copy link

Notifying maintainers:
@jmroot for port python314-devel.

@aeiouaeiouaeiouaeiouaeiouaeiou
Copy link
Contributor Author

@jmroot please review these changes. I don't think it will break anything critically, especially since Python 3.14 is still in alpha testing.

@jmroot
Copy link
Member

jmroot commented Jan 15, 2025

I'm happy to test out changes in the port, but the goal (mine at least) is to get the changes included upstream, so the changes we try here should be exactly the same changes that we propose for adoption upstream. This is why I'm asking to remove #define TARGET_OS_OSX 1 and instead handle it being undefined correctly with the single simplified check.

@aeiouaeiouaeiouaeiouaeiouaeiou
Copy link
Contributor Author

It seems to be fixed now (for some mystical reason my build couldn't find TargetConditionals.h, perhaps I should reinstall Xcode), however the Trac ticket should be closed too.

@aeiouaeiouaeiouaeiouaeiouaeiou aeiouaeiouaeiouaeiouaeiouaeiou deleted the python314-devel-3.14.0a3-compat branch January 16, 2025 11:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

4 participants