Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to 1.24.1 #27377

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Update to 1.24.1 #27377

wants to merge 1 commit into from

Conversation

1o1o1
Copy link
Contributor

@1o1o1 1o1o1 commented Jan 13, 2025

Description

Add "u" key to file browser to sort non-local files first
Fix possible crash on aarch64 when connected to an ADC hub
Slightly improve ADC protocol compliance
Slightly improve C compiler compatibility

Type(s)
  • bugfix
  • enhancement
  • security fix
Tested on

macOS x.y
Xcode x.y / Command Line Tools x.y.z

Verification

Have you

  • followed our Commit Message Guidelines?
  • squashed and minimized your commits?
  • checked that there aren't other open pull requests for the same change?
  • referenced existing tickets on Trac with full URL in commit message?
  • checked your Portfile with port lint?
  • tried existing tests with sudo port test?
  • tried a full install with sudo port -vst install?
  • tested basic functionality of all binary files?
  • checked that the Portfile's most important variants haven't been broken?

Add "u" key to file browser to sort non-local files first 
Fix possible crash on aarch64 when connected to an ADC hub 
Slightly improve ADC protocol compliance
Slightly improve C compiler compatibility
@reneeotten
Copy link
Contributor

reneeotten commented Jan 13, 2025

@1o1o1 thanks for the update! Please amend your commit message so that it follows the usual convention:

"portname: short description"

@@ -3,7 +3,7 @@
PortSystem 1.0

name ncdc
version 1.23.1
version 1.24.1
categories net chat
platforms darwin
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is the default for quite some time now and thus the "platforms" line should be removed. "port lint" warns about that so you should have seen that when you ran the lint check locally.

Copy link
Contributor Author

@1o1o1 1o1o1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok) I'll remove it later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants