Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

game-porting-toolkit: Add patch fixing Steam #27387

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Gcenx
Copy link
Contributor

@Gcenx Gcenx commented Jan 14, 2025

Description

Imported a patch that fixes the Steam client, also allow game-porting-toolkit built on macOS Sonoma to be used on macOS Sequoia and later.

The port is expected to fail with the macOS Sequoia action/buildbot due to requiring an older SDK to build, as MacOSX.sdk still hasn't been updated theres nothing else I can do.

Type(s)
  • enhancement
Tested on

macOS 14.7.2 23H311 x86_64
Xcode 16.2 16C5032a

Verification
  • followed our Commit Message Guidelines?
  • squashed and minimized your commits?
  • checked that there aren't other open pull requests for the same change?
  • checked your Portfile with port lint?
  • tried existing tests with sudo port test?
  • tried a full install with sudo port -vst install?
  • tested basic functionality of all binary files?
  • checked that the Portfile's most important variants haven't been broken?

@reneeotten
Copy link
Contributor

will any of this be incorporated upstream for a next release? Ideally we don't want to carry forward patches with ~2000 lines...

@Gcenx
Copy link
Contributor Author

Gcenx commented Jan 17, 2025

will any of this be incorporated upstream for a next release? Ideally we don't want to carry forward patches with ~2000 lines...

Apple haven't upgraded https://github.com/apple/homebrew-apple in 2 years, if the large patch files are the issue the alternative is I could redo my mirror so it's wine-7.7 + game-porting-toolkit patches then apply all the needed patches and use that as the source instead.

@Gcenx Gcenx marked this pull request as draft January 17, 2025 18:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants