Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ffmpeg7: add pixeldensity feature for retina displays #27440

Merged

Conversation

aeiouaeiouaeiouaeiouaeiouaeiou
Copy link
Contributor

Description

Backport the patch to ffmpeg7, since the ffmpeg-devel port uses v7 branch.

Type(s)
  • bugfix
  • enhancement
  • security fix
Tested on

macOS 10.6.8 10K549 x86_64
Xcode 4.2 4C199

Verification

Have you

  • followed our Commit Message Guidelines?
  • squashed and minimized your commits?
  • checked that there aren't other open pull requests for the same change?
  • referenced existing tickets on Trac with full URL in commit message?
  • checked your Portfile with port lint?
  • tried existing tests with sudo port test?
  • tried a full install with sudo port -vst install?
  • tested basic functionality of all binary files?
  • checked that the Portfile's most important variants haven't been broken?

@macportsbot
Copy link

Notifying maintainers:
@barracuda156 for port ffmpeg7.
@mascguy for port ffmpeg7.

@macportsbot macportsbot added the maintainer: open Affects an openmaintainer port label Jan 21, 2025
@aeiouaeiouaeiouaeiouaeiouaeiou
Copy link
Contributor Author

@mascguy the build still fails on 10.11 machine, it might be worth increasing Clang blacklist to 900.

@mascguy
Copy link
Member

mascguy commented Jan 21, 2025

@mascguy the build still fails on 10.11 machine, it might be worth increasing Clang blacklist to 900.

Sure, go ahead and add it to this PR.

@mascguy
Copy link
Member

mascguy commented Jan 21, 2025

LGTM, will merge once CI completes for 13 and 14.

@mascguy
Copy link
Member

mascguy commented Jan 21, 2025

Thank you!

@mascguy mascguy merged commit 43f587c into macports:master Jan 21, 2025
@aeiouaeiouaeiouaeiouaeiouaeiou aeiouaeiouaeiouaeiouaeiouaeiou deleted the ffmpeg7-pixeldensity branch January 22, 2025 00:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintainer: open Affects an openmaintainer port
Development

Successfully merging this pull request may close these issues.

3 participants