fix v0.13.4 gateway client deserialization #514
Merged
+16
−13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cchudant
force-pushed
the
fix-gateway-client-v0.13.4-deser
branch
2 times, most recently
from
7ed995b to
e369fa2
Compare
cchudant
force-pushed
the
fix-gateway-client-v0.13.4-deser
branch
from
e369fa2 to
d8db06b
Compare
notlesh
approved these changes
Mar 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request type
Please add the labels corresponding to the type of changes your PR introduces:
What is the current behavior?
serde deny_unknown_fields - the reason we put that is because it forced us to support any new fields when syncing from integration and sepolia testnets.
What is the new behavior?
We don't support v0.13.4, and it seems the madara-alliance is not wanting to support it. The CI however tests the import of a few blocks on sepolia, and it is now failing because we have not implemented the new v0.13.4 changes.
This PR allows the tests to pass.
Note that however, the new v0.13.4 blocks probably still can't be imported.
Does this introduce a breaking change?
No