Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tests: use testcontainers.redis for integration tests #208

Closed
wants to merge 1 commit into from
Closed

tests: use testcontainers.redis for integration tests #208

wants to merge 1 commit into from

Conversation

Meir017
Copy link

@Meir017 Meir017 commented May 24, 2024

closes #207

@Meir017
Copy link
Author

Meir017 commented May 24, 2024 •
edited
Loading

@madelson https://github.com/Meir017/DistributedLock/actions/runs/9220468611/job/25367497549
the same 3 tests fail
image

Failed! - Failed: 30, Passed: 218, Skipped: 0, Total: 248, Duration: 1 m 39 s - DistributedLock.Tests.dll (net8.0)

@Meir017
Copy link
Author

Meir017 commented May 24, 2024

@madelson can the invocation of RunLockTaker in the tests be converted to a simple project reference and then calling the method?

@Meir017 Meir017 marked this pull request as ready for review May 24, 2024 07:51
@Meir017 Meir017 force-pushed the tests/redis-test-containers branch from aa2a50d to 117139d Compare May 24, 2024 07:53
@Meir017 Meir017 mentioned this pull request May 27, 2024
Closed
@Meir017 Meir017 closed this Jun 5, 2024
@Meir017
Copy link
Author

Meir017 commented Jun 5, 2024

continued in #211

@Meir017 Meir017 deleted the tests/redis-test-containers branch June 5, 2024 05:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Local development and CI using test containers
1 participant
@Meir017