Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve conditional access tests #722

Open
wants to merge 28 commits into
base: main
Choose a base branch
from

Conversation

tdcthosc
Copy link
Contributor

@tdcthosc tdcthosc commented Mar 4, 2025

Various improvements to multiple Conditional Access tests. Multiple commits for better change visibility and explanations on changes.

tdcthosc added 24 commits March 3, 2025 14:17
… by Microsoft learn in Test-MtCaMfaForAdminManagement
…ces and threw an error "'Invoke-MtGraphRequest' is not recognized"
@tdcthosc tdcthosc requested a review from a team as a code owner March 4, 2025 06:44
Copy link
Contributor

Warning

Gemini is experiencing higher than usual traffic and was unable to create the summary. Please try again in a few hours by commenting /gemini summary.

@tdcthosc
Copy link
Contributor Author

tdcthosc commented Mar 4, 2025

Should resolve #710

@merill
Copy link
Contributor

merill commented Mar 6, 2025

@tdcthosc this are some really good updates! Thanks a lot.

On the Device Code flow, since we are being strict about the policy, it will be nice to show the policies that target device code flow but don't meet our criteria.

This will help the user understand why we are failing the test even though they might have a device code block policy.

Thoughts?

CleanShot 2025-03-06 at 14 43 42

@tdcthosc
Copy link
Contributor Author

tdcthosc commented Mar 6, 2025

@tdcthosc this are some really good updates! Thanks a lot.

On the Device Code flow, since we are being strict about the policy, it will be nice to show the policies that target device code flow but don't meet our criteria.

This will help the user understand why we are failing the test even though they might have a device code block policy.

Thoughts?

I agree and will get to work on that later today.

@merill
Copy link
Contributor

merill commented Mar 6, 2025

Thanks Thomas!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants