Code

Improve ORCA implementation#726

Code

Open

tdcthosc wants to merge 31 commits intomaester365:mainmaester365/maester:mainfrom tdcthosc:tdc-improve-orca-implementationtdcthosc/maester:tdc-improve-orca-implementationCopy head branch name to clipboard

+3,830-1,696

Commits

Commits on Mar 4, 2025

• Improve regular expression for Importance capture, as some has apostrophe in the string, which would split the capture

  tdcthosc

  committed
  81fcd04

  Copy full SHA for 81fcd04

• Updated markdown to be more like other maester tests with a description and also include remediation action provided by ORCA

  tdcthosc

  committed
  22dfdc1

  Copy full SHA for 22dfdc1

• Add SCC parameter to Get-ORCACollection to includeadditional tests as well

  tdcthosc

  committed
  652dfa9

  Copy full SHA for 652dfa9

• Update name capture to improved regular expression

  tdcthosc

  committed
  31b3f72

  Copy full SHA for 31b3f72

• Update pass capture to improved regular expression

  tdcthosc

  committed
  711a786

  Copy full SHA for 711a786

• Bugfix for fail to capture correct information and update to improved regular expression

  tdcthosc

  committed
  4d5b6ca

  Copy full SHA for 4d5b6ca

• Update control capture to improved regular expression

  tdcthosc

  committed
  debd67e

  Copy full SHA for debd67e

• Update area capture to improved regular expression

  tdcthosc

  committed
  da31b0c

  Copy full SHA for da31b0c

• Add punctuation to fail recommendation text if not present to stay consistent between tests

  tdcthosc

  committed
  45f3c3a

  Copy full SHA for 45f3c3a

• Implement handling "SkipInReport"

  tdcthosc

  committed
  a0da640

  Copy full SHA for a0da640

• Additional skipping of test if it failed to check or was not completed (most likely due to missing license)

  tdcthosc

  committed
  3348208

  Copy full SHA for 3348208

• Bugfix to look at the correct result, as tests would pass even if they were not configured correct

  tdcthosc

  committed
  32caa2e

  Copy full SHA for 32caa2e

• Fix typo in skipResult string

  tdcthosc

  committed
  1f1e6da

  Copy full SHA for 1f1e6da

• Only build table in markdown if there is something to loop and only build required columns

  tdcthosc

  committed
  385c2d2

  Copy full SHA for 385c2d2

• Update resultMarkdown fail statement for better synergy

  tdcthosc

  committed
  de2e1f2

  Copy full SHA for de2e1f2

• Bugfix to support checks that has a dash and subnumbered tests, such as check-118

  tdcthosc

  committed
  024da5b

  Copy full SHA for 024da5b

• To be more clear on the purpose of the test, the name should instead be the goal of the test using "pass" string

  tdcthosc

  committed
  bdc01ee

  Copy full SHA for bdc01ee

• To avoid duplicate names when checks are sub-tests there is implemented the functionality to:

  Show description for bced05a
  tdcthosc

  committed
  bced05a

  Copy full SHA for bced05a

• Updated resultMarkdown for better visibility and synergy in the output like other Maester tests

  tdcthosc

  committed
  f18d550

  Copy full SHA for f18d550

• Build new ORCA tests

  tdcthosc

  committed
  e16908c

  Copy full SHA for e16908c

• Remove incorrectly generated tests

  tdcthosc

  committed
  37b6592

  Copy full SHA for 37b6592

• Build new ORCA tests again to verify

  tdcthosc

  committed
  30db0af

  Copy full SHA for 30db0af

• Added exception output before throw as suggested by Gemini bot

  tdcthosc

  committed
  b32e43a

  Copy full SHA for b32e43a

• Added comments as suggested by Gemini bot

  tdcthosc

  committed
  cab3b10

  Copy full SHA for cab3b10

• Added comment to why SCC is specified

  tdcthosc

  committed
  a12d840

  Copy full SHA for a12d840

• Updated FunctionToExport in Maester.psd1 to reflect the new additional tests after resolving test-generation bug

  tdcthosc

  committed
  6fb106b

  Copy full SHA for 6fb106b

• Build new ORCA tests to include new additional comments

  tdcthosc

  committed
  5d316dd

  Copy full SHA for 5d316dd

• Updated FunctionToExport in Maester.psd1 to reflect the new additional tests after resolving test-generation bug

  tdcthosc

  committed
  9215e8e

  Copy full SHA for 9215e8e

Commits on Mar 8, 2025

• Moved "SkipInReport" out of "finally" for better readability

  tdcthosc

  committed
  acef2b4

  Copy full SHA for acef2b4

• Added return null on SkipInReport

  tdcthosc

  committed
  6825b39

  Copy full SHA for 6825b39

• Proposed solution: Do not skip all tests simply because Security & Compliance is not connected. Only 1 test in ORCA rely on SCC. Add SCC boolean to upstream ORCA module check and skip this check if…

  Show description for d1ae7b4
  tdcthosc

  committed
  d1ae7b4

  Copy full SHA for d1ae7b4