Add Nix support #25
Add Nix support #25
Conversation
There was a problem hiding this comment.
Hey, thanks for helping improve the project! I don't use Nix myself but happy to merge this if it makes peoples lives easier.
Some docs would be awesome too!
Is there a reason the full path was specified for the
installbinary?
Can't recall there being any specific reason, all good 👍🏻
flake.nix
Outdated
|
|
||
| hardeningDisable = [ "pic" "format" ]; | ||
| # Install kmod for depmod dependency if we need it | ||
| #nativeBuildInputs = kernel.moduleBuildDependencies ++ [ kmod ]; |
There was a problem hiding this comment.
What's the motivation for leaving this commented? If it's a common-use case, is there a better way to support it?
There was a problem hiding this comment.
I noticed that depmod is used in the Makefile, but everything seems to work without. Is it OK, if I skip it? I didn't really understand its purpose.
There was a problem hiding this comment.
depmod is required for modprobe to work properly, I think it uses it to figure out what other modules to implicitly load, so it should be run after new modules have been installed.
It might have worked on your system without depmod by chance, but I wouldn't rely on that behavior.
There was a problem hiding this comment.
I will remove it, because it seems to work and I saw that line being disabled in other NixOS kernel modules. It probably works differently.
There was a problem hiding this comment.
I'm not familiar with Nix, but this is surprising.
You may wanna ask other Nix developers/maintainers who may know about such things why it's not needed there (maybe Nix calls depmod or something equivalent automatically for kernel modules? Just a possible explanation, I really don't know)
There was a problem hiding this comment.
I asked and they said it is not required during build time.
Thank you for the awesome work! I have added some documentation. This is enough to get the basics working on NixOS. If other people start using it, we could consider adding more options to enhance its functionality and flexibility. Two things that come to mind are automatically disabling the blinking and adding an option to set the brightness. |
This change allows NixOS users to easily activate the asustor-platform-driver modules. Basically they only need to include the repository and set
hardware.asustor.enable = true. I will also add some documentation if you are willing to merge this change.Is there a reason the full path was specified for the
installbinary?