updateCustomerV2 code style fixes #341
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
melnikovi
reviewed
Nov 11, 2019
| } | ||
| ``` | ||
|
|
||
| **updateCustomerPassword** | ||
|
|
||
| ```graphql | ||
| mutation { | ||
| updateCustomerPassword(password: String!, old_password: String!): Customer | ||
| updateCustomerPassword(currentPassword: String!, newPassword: String!): CustomerOutput |
There was a problem hiding this comment.
According to #269, fields should be snake case. I would also propose to keep password and old_password arguments.
There was a problem hiding this comment.
But this is argument of the mutation.
Regarding naming, I think we need more thoughts here.
@buskamuza @paliarush
melnikovi
reviewed
Nov 11, 2019
| @@ -15,7 +15,7 @@ Deprecate `updateCustomer` mutation in favor of `updateCustomerV2`. `CustomerUpd | |||
|
|
|||
| ```graphql | |||
| mutation { | |||
| updateCustomerV2(input: CustomerUpdateInput!): Customer | |||
| updateCustomerV2(input: CustomerUpdateInput!): CustomerOutput | |||
There was a problem hiding this comment.
I agree that it would not be consistent with existing operations. But I would only change it if we think that we may want to add more data in the future.
…ation is already implemented
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
CustomerOutputalready exists and is used increateCustomer (input: CustomerInput!): CustomerOutputmutation.updateCustomerPasswordbecausechangeCustomerPassword(currentPassword: String!, newPassword: String!): Customeralready existsRequested Reviewers
@paliarush
@melnikovi